Skip to content

Update storage lib to enable bucket creation on startup #224

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Oct 27, 2022

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Oct 25, 2022

Description

Creates bucket(s) on startup based on the values specified in the new config key createBuckets

        "createBuckets": "monaideploy"

This new key (createBuckets) is separate from the bucketName and temporaryBucketName configurations used for uploading data.

Status

*Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the enhancement Enhancement to existing feature label Oct 25, 2022
@mocsharp mocsharp added this to the 0.3.3 milestone Oct 25, 2022
@mocsharp mocsharp self-assigned this Oct 25, 2022
@codecov
Copy link

codecov bot commented Oct 25, 2022

Codecov Report

Merging #224 (7d146a8) into develop (73ffe1d) will increase coverage by 0.01854%.
The diff coverage is n/a.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #224         +/-   ##
===================================================
+ Coverage   92.81785%   92.83639%   +0.01853%     
===================================================
  Files            273         273                 
  Lines          16179       16179                 
  Branches         830         830                 
===================================================
+ Hits           15017       15020          +3     
+ Misses           906         904          -2     
+ Partials         256         255          -1     
Flag Coverage Δ
unittests 92.83639% <ø> (+0.01853%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...ateway/Services/Connectors/DataRetrievalService.cs 80.71429% <0.00000%> (+0.71429%) ⬆️
...Gateway/Repositories/InferenceRequestRepository.cs 95.23810% <0.00000%> (+1.19048%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 73ffe1d...7d146a8. Read the comment docs.

Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp merged commit 90ea617 into develop Oct 27, 2022
@mocsharp mocsharp deleted the vchang/gh-221 branch October 27, 2022 15:00
@github-actions
Copy link

🎉 This issue has been resolved in version 0.3.3 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement Enhancement to existing feature
Projects
Development

Successfully merging this pull request may close these issues.

2 participants