Skip to content

Update licenses & CI #234

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Nov 2, 2022
Merged

Update licenses & CI #234

merged 9 commits into from
Nov 2, 2022

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Oct 31, 2022

Description

  • Update licenses to reflect recent dependabot changes
  • Fix skywalking-eye failure
  • Use dotnet's built-in vulnerability scan for nuget packages

Status

*Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp added the build Build & build workflow label Oct 31, 2022
@mocsharp mocsharp self-assigned this Oct 31, 2022
Signed-off-by: Victor Chang <[email protected]>
Signed-off-by: Victor Chang <[email protected]>
@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #234 (92c8ea6) into develop (727fffd) will decrease coverage by 0.01236%.
The diff coverage is 66.66667%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #234         +/-   ##
===================================================
- Coverage   92.84257%   92.83021%   -0.01237%     
===================================================
  Files            273         273                 
  Lines          16179       16179                 
  Branches         830         830                 
===================================================
- Hits           15021       15019          -2     
- Misses           903         905          +2     
  Partials         255         255                 
Flag Coverage Δ
unittests 92.83021% <66.66667%> (-0.01237%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...icsGateway/Services/Storage/ObjectUploadService.cs 59.63303% <66.66667%> (ø)
...maticsGateway/Services/HealthLevel7/MllpService.cs 76.92308% <0.00000%> (-1.09891%) ⬇️
...ateway/Services/Connectors/DataRetrievalService.cs 80.71429% <0.00000%> (-0.35715%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8aa247f...92c8ea6. Read the comment docs.

@mocsharp mocsharp changed the title Update licenses Update licenses & CI Oct 31, 2022
@mocsharp mocsharp requested review from a team, jackschofield23 and neildsouth and removed request for a team October 31, 2022 22:30
@mocsharp mocsharp merged commit 16e1cb7 into develop Nov 2, 2022
@mocsharp mocsharp deleted the vchang/update-licenses branch November 2, 2022 20:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Build & build workflow
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants