Skip to content

Resets ActionBlock if faulted or cancelled. #385

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 20, 2023

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Apr 18, 2023

Description

Checks and resets ActionBlock<> queues used for moving and publishing payloads if unable to post any messages to them.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the bug Something isn't working label Apr 18, 2023
@mocsharp mocsharp added this to the 0.3.17 milestone Apr 18, 2023
@mocsharp mocsharp self-assigned this Apr 18, 2023
@mocsharp mocsharp requested a review from neildsouth April 18, 2023 22:44
@codecov
Copy link

codecov bot commented Apr 18, 2023

Codecov Report

Merging #385 (0723a6f) into develop (ac7d557) will decrease coverage by 0.15088%.
The diff coverage is 73.79679%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #385         +/-   ##
===================================================
- Coverage   79.75442%   79.60354%   -0.15089%     
===================================================
  Files            327         328          +1     
  Lines          20523       20582         +59     
  Branches         937         954         +17     
===================================================
+ Hits           16368       16384         +16     
- Misses          3838        3873         +35     
- Partials         317         325          +8     
Flag Coverage Δ
unittests 79.60354% <73.79679%> (-0.15089%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Api/Storage/Payload.cs 97.29730% <ø> (ø)
src/Common/ExtensionMethods.cs 92.85714% <0.00000%> (-7.14286%) ⬇️
src/Configuration/DicomWebConfiguration.cs 100.00000% <ø> (ø)
src/Configuration/ScuConfiguration.cs 100.00000% <ø> (ø)
.../InformaticsGateway/Common/PostPayloadException.cs 0.00000% <0.00000%> (ø)
...ay/Services/Connectors/PayloadMoveActionHandler.cs 70.65868% <0.00000%> (-2.06860%) ⬇️
...ces/Connectors/PayloadNotificationActionHandler.cs 78.94737% <0.00000%> (-2.38596%) ⬇️
...csGateway/Services/Export/DicomWebExportService.cs 86.30137% <ø> (ø)
...maticsGateway/Services/Export/ExportServiceBase.cs 84.11765% <46.15385%> (-1.68483%) ⬇️
.../Services/Connectors/PayloadNotificationService.cs 63.63636% <56.89655%> (-9.00515%) ⬇️
... and 5 more

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac7d557...0723a6f. Read the comment docs.

Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp merged commit a83ef62 into develop Apr 20, 2023
@github-actions
Copy link

🎉 This issue has been resolved in version 0.3.17 🎉

The release is available on:

@mocsharp mocsharp deleted the vchang/pyaload-notification branch August 10, 2023 18:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants