Spawn new thread for processing echo requests #396
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoeBatt1989
approved these changes
May 31, 2023
Signed-off-by: Mindaugas Baltrimas <[email protected]>
samrooke
approved these changes
May 31, 2023
Codecov Report
@@ Coverage Diff @@
## develop #396 +/- ##
===================================================
+ Coverage 79.63869% 79.64855% +0.00986%
===================================================
Files 328 328
Lines 20647 20657 +10
Branches 955 955
===================================================
+ Hits 16443 16453 +10
Misses 3876 3876
Partials 328 328
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report in Codecov by Sentry.
|
neildsouth
added a commit
that referenced
this pull request
Jun 1, 2023
Spawn new thread for processing echo requests (#396)
|
🎉 This issue has been resolved in version 0.3.20 🎉 The release is available on: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Currently, echo requests are blocking the
ScuServicethread allowing for only one request to be processed at a time. Long running requests (such as the ones failing to reach its target) will cause consecutive echo requests to be delayed, eventually resulting in timeouts. To avoid this, the PR makes a change to spawn a new thread for each call toProcess.This also adds a change that passes the
HttpContext.RequestAbortedcancellation token down the chain so that processing of echo requests could be cancelled if the http request is aborted.Status
Ready
Types of changes