Skip to content

Include project references in the nuget package #478

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Sep 19, 2023
Merged

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Sep 19, 2023

Description

Fix to include Monai.Deploy.InformaticsGateway.Common in the Monai.Deploy.InformaticsGateway.Api Nuget package.

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the bug Something isn't working label Sep 19, 2023
@mocsharp mocsharp added this to the 0.4.2 milestone Sep 19, 2023
@mocsharp mocsharp requested a review from neildsouth September 19, 2023 14:45
@mocsharp mocsharp self-assigned this Sep 19, 2023
Signed-off-by: Victor Chang <[email protected]>
@codecov
Copy link

codecov bot commented Sep 19, 2023

Codecov Report

Merging #478 (7a455e8) into develop (047406b) will decrease coverage by 0.00973%.
The diff coverage is 80.00000%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop        #478         +/-   ##
===================================================
- Coverage   78.81182%   78.80209%   -0.00973%     
===================================================
  Files            379         379                 
  Lines          24306       24309          +3     
  Branches        1083        1083                 
===================================================
  Hits           19156       19156                 
- Misses          4775        4778          +3     
  Partials         375         375                 
Flag Coverage Δ
unittests 78.80209% <80.00000%> (-0.00973%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ormaticsGateway/Services/Scp/ScpServiceInternal.cs 77.22772% <80.00000%> (-0.32330%) ⬇️

... and 2 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 047406b...7a455e8. Read the comment docs.

Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp merged commit 8ceee8a into develop Sep 19, 2023
@mocsharp mocsharp deleted the vchang/nuget-bug branch September 19, 2023 19:19
@mocsharp mocsharp modified the milestones: 0.4.2, 0.5.0 Jun 12, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

2 participants