Skip to content

[DEMO] App runner demo #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Mar 10, 2022
Merged

[DEMO] App runner demo #57

merged 9 commits into from
Mar 10, 2022

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Feb 11, 2022

Description

A demo application in python that subscribes to md.workflow.request events, downloads files specified in the message from storage service and then launches the dicom_series_to_image_app.

Status

Work in progress

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally by running ./src/run-tests-in-docker.sh.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the demo label Feb 11, 2022
@mocsharp mocsharp self-assigned this Feb 11, 2022
@codecov
Copy link

codecov bot commented Feb 11, 2022

Codecov Report

Merging #57 (fe16d15) into develop (0980fe2) will increase coverage by 0.02372%.
The diff coverage is 95.03106%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop         #57         +/-   ##
===================================================
+ Coverage   92.55170%   92.57542%   +0.02371%     
===================================================
  Files            201         203          +2     
  Lines          12137       12297        +160     
  Branches         622         622                 
===================================================
+ Hits           11233       11384        +151     
- Misses           722         730          +8     
- Partials         182         183          +1     
Flag Coverage Δ
unittests 92.57542% <95.03106%> (+0.02371%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...grations/InformaticsGatewayContextModelSnapshot.cs 0.00000% <0.00000%> (ø)
...rc/Database/Migrations/20220310211304_R2_Update.cs 63.63636% <63.63636%> (ø)
...se/Migrations/20220310211304_R2_Update.Designer.cs 100.00000% <100.00000%> (ø)
...Test/Services/Storage/SpaceReclaimerServiceTest.cs 97.77778% <0.00000%> (-2.22222%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0980fe2...fe16d15. Read the comment docs.

@mocsharp mocsharp requested review from GreySeaWolf, joshliberty, MMelQin, whoisj and a team March 1, 2022 17:33
@mocsharp mocsharp force-pushed the vchang/app_runner_demo branch from 0b794c5 to f923253 Compare March 10, 2022 20:58
@mocsharp mocsharp merged commit eef9c7e into develop Mar 10, 2022
@mocsharp mocsharp deleted the vchang/app_runner_demo branch March 10, 2022 21:49
@mocsharp mocsharp added this to the 0.2.0 milestone Apr 7, 2022
@github-actions
Copy link

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
Development

Successfully merging this pull request may close these issues.

1 participant