Skip to content

Update .editorconfig to enforce coding styles, naming rules #62

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Mar 10, 2022

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Mar 3, 2022

Description

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally by running ./src/run-tests-in-docker.sh.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp requested a review from joshliberty March 3, 2022 00:50
@mocsharp mocsharp marked this pull request as draft March 3, 2022 00:50
@mocsharp mocsharp force-pushed the vchang/editorconfig branch 2 times, most recently from 504056d to e821a17 Compare March 8, 2022 23:26
@codecov
Copy link

codecov bot commented Mar 8, 2022

Codecov Report

Merging #62 (9473c1b) into develop (d4c6b34) will increase coverage by 4.10808%.
The diff coverage is 88.30486%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop         #62         +/-   ##
===================================================
+ Coverage   88.44362%   92.55170%   +4.10808%     
===================================================
  Files            163         201         +38     
  Lines           7511       12137       +4626     
  Branches         561         622         +61     
===================================================
+ Hits            6643       11233       +4590     
- Misses           692         722         +30     
- Partials         176         182          +6     
Flag Coverage Δ
unittests 92.55170% <88.30486%> (+4.10808%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Api/BaseApplicationEntity.cs 100.00000% <ø> (ø)
src/Api/LoggingDataDictionary.cs 100.00000% <ø> (ø)
src/Api/MessageBroker/ExportCompleteMessage.cs 75.00000% <ø> (ø)
src/Api/MessageBroker/ExportRequestMessage.cs 100.00000% <ø> (ø)
src/Api/MessageBroker/JsonMessage.cs 77.77778% <ø> (ø)
src/Api/MessageBroker/Message.cs 67.85714% <ø> (ø)
src/Api/MessageBroker/MessageBase.cs 100.00000% <ø> (ø)
src/Api/MessageBroker/MessageReceivedEventArgs.cs 100.00000% <ø> (ø)
src/Api/MonaiApplicationEntity.cs 100.00000% <ø> (ø)
src/Api/Rest/HealthStatusResponse.cs 100.00000% <ø> (ø)
... and 225 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update d4c6b34...9473c1b. Read the comment docs.

@mocsharp mocsharp force-pushed the vchang/editorconfig branch from e821a17 to 0b909e8 Compare March 8, 2022 23:34
@mocsharp mocsharp marked this pull request as ready for review March 10, 2022 16:36
@mocsharp mocsharp force-pushed the vchang/editorconfig branch from 42d7047 to 263eaca Compare March 10, 2022 19:12
Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp force-pushed the vchang/editorconfig branch from 263eaca to 9473c1b Compare March 10, 2022 19:39
@mocsharp mocsharp merged commit 0980fe2 into develop Mar 10, 2022
@mocsharp mocsharp deleted the vchang/editorconfig branch March 10, 2022 20:47
@mocsharp
Copy link
Collaborator Author

Closes #60 and #61

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants