Skip to content

Use .NET 6 structured logging #67

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Mar 17, 2022
Merged

Use .NET 6 structured logging #67

merged 8 commits into from
Mar 17, 2022

Conversation

mocsharp
Copy link
Collaborator

Fixes #65 .

Description

  • Address warnings and message reported by SonarQube
  • Use .NET 6.0 high performance structured logging to remove CA2254 messages

Status

Ready/Work in progress/Hold

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally by running ./src/run-tests-in-docker.sh.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the bug Something isn't working label Mar 16, 2022
@mocsharp mocsharp added this to the 0.2.0 milestone Mar 16, 2022
@mocsharp mocsharp self-assigned this Mar 16, 2022
@mocsharp mocsharp force-pushed the vchang/sonar branch 4 times, most recently from 45c4f06 to b411488 Compare March 16, 2022 22:59
Signed-off-by: Victor Chang <[email protected]>
@codecov
Copy link

codecov bot commented Mar 16, 2022

Codecov Report

Merging #67 (59f6583) into develop (0fca397) will increase coverage by 92.36525%.
The diff coverage is 87.34622%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##            develop         #67          +/-   ##
===================================================
+ Coverage   0.00000%   92.36525%   +92.36525%     
===================================================
  Files           203         206           +3     
  Lines         12344       12430          +86     
  Branches        624         626           +2     
===================================================
+ Hits              0       11481       +11481     
+ Misses        12343         764       -11579     
- Partials          1         185         +184     
Flag Coverage Δ
unittests 92.36525% <87.34622%> (+92.36525%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Api/Storage/Payload.cs 100.00000% <ø> (+100.00000%) ⬆️
src/CLI/Commands/ConfigurationException.cs 25.00000% <0.00000%> (+25.00000%) ⬆️
src/CLI/Logging/ConsoleLogger.cs 92.85714% <ø> (+92.85714%) ⬆️
src/CLI/Logging/ConsoleLoggerProvider.cs 0.00000% <ø> (ø)
src/CLI/Program.cs 0.00000% <0.00000%> (ø)
...c/Client/Test/HttpResponseMessageExtensionsTest.cs 100.00000% <ø> (+100.00000%) ⬆️
src/Configuration/ScpConfiguration.cs 100.00000% <ø> (+100.00000%) ⬆️
...c/Configuration/Test/ConfigurationValidatorTest.cs 100.00000% <ø> (+100.00000%) ⬆️
src/Database/InformaticsGatewayContextFactory.cs 0.00000% <0.00000%> (ø)
src/DicomWebClient/DicomWebClient.cs 96.42857% <ø> (+96.42856%) ⬆️
... and 273 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fca397...59f6583. Read the comment docs.

Signed-off-by: Victor Chang <[email protected]>
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

81.1% 81.1% Coverage
0.0% 0.0% Duplication

@mocsharp mocsharp merged commit 1e486f8 into develop Mar 17, 2022
@mocsharp mocsharp deleted the vchang/sonar branch March 17, 2022 00:50
@github-actions
Copy link

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
Development

Successfully merging this pull request may close these issues.

Address SonarQube reported issues
1 participant