Skip to content

Support allow-list for SOP classes. #91

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 27 commits into from
Jun 28, 2022
Merged

Support allow-list for SOP classes. #91

merged 27 commits into from
Jun 28, 2022

Conversation

mocsharp
Copy link
Collaborator

@mocsharp mocsharp commented Jun 14, 2022 •
edited
Loading

Fixes #33 .

Description

Allows user to define a list of allowed SOP classes for each configured AE Title.
The allowed-sop-classes list is mutually-exclusive to the ignored-sop-classes list.

Also updated System.CommandLine to latest beta build (2.0.0-beta4.22272.1)

Status

Ready

Types of changes

  • Non-breaking change (fix or new feature that would not break existing functionality).
  • Breaking change (fix or new feature that would cause existing functionality to change).
  • New tests added to cover the changes.
  • All tests passed locally.
  • Documentation comments included/updated.
  • User guide updated.
  • I have updated the changelog

@mocsharp mocsharp added the enhancement Enhancement to existing feature label Jun 14, 2022
@mocsharp mocsharp added this to the 0.2.0 milestone Jun 14, 2022
@mocsharp mocsharp requested a review from a team June 14, 2022 00:04
@mocsharp mocsharp self-assigned this Jun 14, 2022
@codecov
Copy link

codecov bot commented Jun 14, 2022 •
edited
Loading

Codecov Report

Merging #91 (5b49600) into develop (cf9c64f) will decrease coverage by 0.05079%.
The diff coverage is 91.09005%.

Impacted file tree graph

@@                 Coverage Diff                 @@
##             develop         #91         +/-   ##
===================================================
- Coverage   93.73240%   93.68161%   -0.05079%     
===================================================
  Files            207         222         +15     
  Lines          12429       13342        +913     
  Branches         638         703         +65     
===================================================
+ Hits           11650       12499        +849     
- Misses           565         611         +46     
- Partials         214         232         +18
Flag Coverage Δ
unittests 93.68161% <91.09005%> (-0.05079%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/Api/Rest/InferenceRequestException.cs 25.00000% <0.00000%> (-25.00000%) ⬇️
src/CLI/Commands/ConfigCommand.cs 100.00000% <ø> (ø)
src/CLI/Commands/RestartCommand.cs 100.00000% <ø> (ø)
src/CLI/Commands/StartCommand.cs 100.00000% <ø> (ø)
src/CLI/Commands/StatusCommand.cs 100.00000% <ø> (ø)
src/CLI/Commands/StopCommand.cs 100.00000% <ø> (ø)
src/Client/Test/AeTitleServiceTest.cs 100.00000% <ø> (ø)
src/Configuration/ConfigurationValidator.cs 96.87500% <ø> (ø)
src/Configuration/StorageConfiguration.cs 75.00000% <ø> (ø)
...grations/InformaticsGatewayContextModelSnapshot.cs 0.00000% <0.00000%> (ø)
... and 63 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6826326...5b49600. Read the comment docs.

@mocsharp mocsharp force-pushed the vchang/33-allowed-sop-classes branch from b6c7cad to bbc5365 Compare June 14, 2022 02:56
@mocsharp mocsharp force-pushed the vchang/28-dicomweb-stow branch 3 times, most recently from e00f6d0 to 791c657 Compare June 22, 2022 23:01
mocsharp added 20 commits June 24, 2022 08:48
@mocsharp
gh-28 Remove Newtonsoft.Json where possible
93c014f 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
gh-28 Use JsonStringEnumMemberConverter in IG client
50601e1 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
gh-28 Fix integration test failure due to JSON serializer change
199c694 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
gh-28 Fix unit test failure due to JSON serializer change
adbb737 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
gh-28 Add DICOMweb STOW API
eb3afce 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
gh-28 Unit test for DICOMweb STOW-RS
888a369 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
gh-28 Remove Newtonsoft.Json where possible
eb1c94c 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
gh-28 Use JsonStringEnumMemberConverter in IG client
7a77c8a 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
gh-28 Fix integration test failure due to JSON serializer change
c3a9366 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
gh-28 Fix unit test failure due to JSON serializer change
215890e 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
gh-28 Add DICOMweb STOW integration test feature
a20dcd0 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
gh-28 Fix unit test & integration test
66b2d06 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
gh-28 Fix warnings
7d7b2ef 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
gh-28 Handles zero length stream and no content requests
891f7cc 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
gh-28 Update user guide
8834ffb 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
gh-28 Update changelog
4bc07ec 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
gh-28 Fix unit test
bd1865e 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
gh-28 Restore default temp storage path
893e350 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
gh-28 Ignore instances if StudyInstanceUIDs don't match
eaf830d 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp
Fix merge conflicts
086e963 
Signed-off-by: Victor Chang <[email protected]>
@mocsharp mocsharp force-pushed the vchang/28-dicomweb-stow branch from 791c657 to 086e963 Compare June 24, 2022 15:50
Base automatically changed from vchang/28-dicomweb-stow to develop June 28, 2022 15:21
@mocsharp mocsharp force-pushed the vchang/33-allowed-sop-classes branch from bbc5365 to 5b49600 Compare June 28, 2022 18:53
@mocsharp mocsharp merged commit 4f43589 into develop Jun 28, 2022
@mocsharp mocsharp deleted the vchang/33-allowed-sop-classes branch June 28, 2022 21:02
mocsharp added a commit that referenced this pull request Aug 19, 2022
@mocsharp
Support allow-list for SOP classes. (#91)
09537f9 
* gh-33 Support allow-list for SOP classes.
* gh-33 Update DB migration

Signed-off-by: Victor Chang <[email protected]>
@github-actions
Copy link

🎉 This issue has been resolved in version 0.2.0 🎉

The release is available on:

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jackschofield23 jackschofield23 jackschofield23 approved these changes

Assignees

@mocsharp mocsharp

Labels
enhancement Enhancement to existing feature
Projects
Clinical Data Pipelines
Status: Done
Milestone
0.2.0
Development

Successfully merging this pull request may close these issues.

Use allow-list for expected SOP classes
2 participants
@mocsharp @jackschofield23