Skip to content

Drop check of monai.utils.get_torch_version_tuple() >= (1, 6) #1072

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 28, 2022
Merged

Drop check of monai.utils.get_torch_version_tuple() >= (1, 6) #1072

merged 1 commit into from
Nov 28, 2022

Conversation

Shadow-Devil
Copy link
Contributor

Fixes #509

Description

Drop check of monai.utils.get_torch_version_tuple() >= (1, 6) because the core codebase now requires at least torch 1.6. See also here

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

@Shadow-Devil
Drop check of monai.utils.get_torch_version_tuple() >= (1, 6)
16c0761 
because the core codebase now requires at least torch 1.6
Fixes Project-MONAI#509
wyli
wyli approved these changes Nov 28, 2022
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

there are two notebooks with the amp

  • acceleration/automatic_mixed_precision.ipynb
  • modules/batch_output_transform.ipynb
    I guess it's a minor issue and keeping them is a good reminder of the feature availability

@wyli wyli merged commit 85d441b into Project-MONAI:main Nov 28, 2022
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
@Shadow-Devil
Drop check of monai.utils.get_torch_version_tuple() >= (1, 6) (Projec…
3bfdea9 
…t-MONAI#1072)

Fixes Project-MONAI#509

### Description
Drop check of monai.utils.get_torch_version_tuple() >= (1, 6) because
the core codebase now requires at least torch 1.6. See also
[here](Project-MONAI/MONAI#3353)

### Checks
- [x] Notebook runs automatically `./runner [-p <regex_pattern>]`
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

drop the check of monai.utils.get_torch_version_tuple() >= (1, 6)
2 participants
@Shadow-Devil @wyli