Skip to content

494 reenable testing #1074

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Nov 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion .github/workflows/test-modified.yml
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
name: build
name: premerge-notebooks

on:
# quick tests of modified notebooks for every pull request
Expand All @@ -25,7 +25,12 @@ jobs:
run: |
which python
nvidia-smi
rm -rf ../../MONAI/MONAI
python -m pip install --upgrade pip wheel
pip uninstall -y monai
pip uninstall -y monai
pip uninstall -y monai-weekly
pip uninstall -y monai-weekly # make sure there's no existing installation
BUILD_MONAI=0 python -m pip install git+https://github.com/Project-MONAI/MONAI#egg=MONAI
python -m pip install -r https://raw.githubusercontent.com/Project-MONAI/MONAI/main/requirements-dev.txt
- uses: actions/checkout@v3
Expand Down
4 changes: 2 additions & 2 deletions deep_atlas/deep_atlas_tutorial.ipynb
Original file line number Diff line number Diff line change
Expand Up @@ -70,7 +70,7 @@
" If we want a deep neural network to do registration, then we can use the segmentation algorithm in this manner to create an objective to train against. We refer to the resulting loss function as _anatomy loss_.\n",
" <br>\n",
" \n",
"- _Reg helps seg:_ Suppose we have a great registration algorithm that can deform one image to another in an anatomically realistic way. Then given just _one_ manually created segmentation, we have an equally great segmentaion algorithm:\n",
"- _Reg helps seg:_ Suppose we have a great registration algorithm that can deform one image to another in an anatomically realistic way. Then given just _one_ manually created segmentation, we have an equally great segmentation algorithm:\n",
" 1. Register the image you want to segment to your _atlas_, the single image for which you already have a segmentation.\n",
" 2. Use the deformation from the registration to warp the atlas's segmentation back onto to your image.\n",
" \n",
Expand Down Expand Up @@ -2436,7 +2436,7 @@
" seg2 = seg2_predicted # Use this in anatomy loss\n",
"\n",
" else: # seg2 available, but no seg1\n",
" assert('seg2' in batch.keys())\n",
" assert 'seg2' in batch.keys()\n",
" seg2 = monai.networks.one_hot(batch['seg2'].to(device), num_segmentation_classes)\n",
" loss_metric = dice_loss2(seg2_predicted, seg2)\n",
" loss_supervised = loss_metric\n",
Expand Down
1 change: 0 additions & 1 deletion runner.sh
Original file line number Diff line number Diff line change
Expand Up @@ -76,7 +76,6 @@ pattern="-and -name '*' -and ! -wholename '*federated_learning*'\
-and ! -wholename '*profiling_train_base_nvtx*'\
-and ! -wholename '*benchmark_global_mutual_information*'\
-and ! -wholename '*spleen_segmentation_3d_visualization_basic*'\
-and ! -wholename '*deep_atlas_tutorial*'\
-and ! -wholename '*nuclick_infer*'\
-and ! -wholename '*nuclick_training_notebook*'\
-and ! -wholename '*full_gpu_inference_pipeline*'\
Expand Down