Skip to content

Add tutorial to extend bundle workflow with event-handler #1098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 6 commits into from
Dec 14, 2022
Merged

Add tutorial to extend bundle workflow with event-handler #1098

merged 6 commits into from
Dec 14, 2022

Conversation

Nic-Ma
Copy link
Contributor

@Nic-Ma Nic-Ma commented Dec 8, 2022

Fixes Project-MONAI/MONAI#5489.

Description

This PR added a tutorial document to extend a bundle workflow with event-handler.

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

@Nic-Ma Nic-Ma mentioned this pull request Dec 8, 2022
Closed
@Nic-Ma Nic-Ma force-pushed the bundle-handler-guide branch from 27e0a48 to 51d5799 Compare December 13, 2022 15:07
@Nic-Ma Nic-Ma marked this pull request as ready for review December 13, 2022 15:08
@Nic-Ma Nic-Ma changed the title [WIP] Add tutorial to extend bundle workflow with event-handler Add tutorial to extend bundle workflow with event-handler Dec 13, 2022
@Nic-Ma Nic-Ma requested a review from wyli December 13, 2022 15:16
wyli
wyli approved these changes Dec 13, 2022
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me, could you also share some techniques on how to debug...also monai.handlers.from_engine(...first=True) is typically very not intuitive, would be great if that could be explained if possible

@Nic-Ma
Copy link
Contributor Author

Nic-Ma commented Dec 14, 2022

looks good to me, could you also share some techniques on how to debug...also monai.handlers.from_engine(...first=True) is typically very not intuitive, would be great if that could be explained if possible

Sure, added in the latest commit.
Could you please help review it again?

Thanks.

KumoLiu
KumoLiu approved these changes Dec 14, 2022
View reviewed changes
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It looks good to me. Thanks!

@wyli wyli merged commit 8dab339 into main Dec 14, 2022
@wyli wyli deleted the bundle-handler-guide branch December 14, 2022 08:26
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
@Nic-Ma @pre-commit-ci
Add tutorial to extend bundle workflow with event-handler (Project-MO…
5c15916 
…NAI#1098)

Fixes Project-MONAI/MONAI#5489.

### Description
This PR added a tutorial document to extend a bundle workflow with
event-handler.

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Notebook runs automatically `./runner [-p <regex_pattern>]`

Signed-off-by: Nic Ma <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

@KumoLiu KumoLiu KumoLiu approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

developer's guide for monai.engines (+ bundle)
3 participants
@Nic-Ma @wyli @KumoLiu