-
Notifications
You must be signed in to change notification settings - Fork 739
Update HoVerNet pipeline #1101
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update HoVerNet pipeline #1101
Conversation
Signed-off-by: KumoLiu <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: KumoLiu <[email protected]>
for more information, see https://pre-commit.ci
update prepare_patches Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @KumoLiu, it looks good to me. just few comments of the texts.
Signed-off-by: KumoLiu <[email protected]>
@KumoLiu, could you please update the default mode of other hovernet pipelines too? thanks tutorials/pathology/hovernet/evaluation.py Line 142 in 5a49733
tutorials/pathology/hovernet/inference.py Line 189 in 5a49733
|
Signed-off-by: KumoLiu <[email protected]>
Of course, have updated! |
@KumoLiu this one needs to be fixed too. Thanks tutorials/pathology/hovernet/inference.py Line 136 in 5a49733
|
Signed-off-by: KumoLiu <[email protected]>
change to fast mode Signed-off-by: KumoLiu <[email protected]>
Hi @drbeh, I have already updated the performance curve, could you please double-check the license descriptions in the README, if that's ok I think this PR can be merged, thanks! |
Signed-off-by: KumoLiu <[email protected]>
…utorials into update-hovernet-readme
update SaveImaged Signed-off-by: KumoLiu <[email protected]>
in the readme and notebookt I think we should cite this paper https://www.sciencedirect.com/science/article/abs/pii/S1361841519301045 instead of the arxiv version. do we need an acknowledgement section for the original author/implementations? the detection folder's readme is a good example https://github.com/Project-MONAI/tutorials/tree/main/detection#acknowledgement cc @drbeh @JHancox |
I agree with @wyli! although we don't have any external contributor to acknowledge. @KumoLiu would it be possible to update them using the following citation? thanks Simon Graham, Quoc Dang Vu, Shan E Ahmed Raza, Ayesha Azam, Yee Wah Tsang, Jin Tae Kwak, Nasir Rajpoot, Hover-Net: Simultaneous segmentation and classification of nuclei in multi-tissue histology images, Medical Image Analysis, 2019 |
Signed-off-by: KumoLiu <[email protected]>
…utorials into update-hovernet-readme
Signed-off-by: KumoLiu <[email protected]>
Fixes #. ### Description add training mode descriptions in README update prepare_patches.py change to "fast" mode ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [ ] Notebook runs automatically `./runner [-p <regex_pattern>]` Signed-off-by: KumoLiu <[email protected]>
Fixes #.
Description
add training mode descriptions in README
update prepare_patches.py
change to "fast" mode
Checks
./runner [-p <regex_pattern>]