-
Notifications
You must be signed in to change notification settings - Fork 739
fix pep 8 for all previously-excluded notebooks #1137
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Mingxin Zheng <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
for more information, see https://pre-commit.ci
please be careful when fixing the new pep8 issues, there's no automated tests to verify the code changes... |
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Hi @wyli , I start to do some manual checks on the notebooks that I touched. The coverage will be limited, and I can see some notebook outside the coverage of our CI/CD is not running correctly, like this one #1139 . Between fixing the bug in this PR or in another PR, I am inclined to the latter if it is not caused by my changes, so that we can make the PR as atomic as possible. |
sure, this looks good to me, if @Nic-Ma doesn't have any other comments let's merge it first. |
Hi @binliunls @mingxin-zheng , Will this PR conflict with #1100? Thanks. |
@binliunls my edits here rearrange some code blocks in |
You can merge first. I will then merge your update to my repo. |
Thanks @binliunls , I have just merged mine to the |
Signed-off-by: Mingxin Zheng <[email protected]> Fixes Project-MONAI#1136 . ### Description The PR expands the scope of PEP 8 checks to cover some notebooks there were previously excluded ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Notebook runs automatically `./runner --no-run` Signed-off-by: Mingxin Zheng <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: Wenqi Li <[email protected]>
Signed-off-by: Mingxin Zheng [email protected]
Fixes #1136 .
Description
The PR expands the scope of PEP 8 checks to cover some notebooks there were previously excluded
Checks
./runner --no-run