Skip to content

fix pep 8 for all previously-excluded notebooks #1137

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 5, 2023

Conversation

mingxin-zheng
Copy link
Contributor

Signed-off-by: Mingxin Zheng [email protected]

Fixes #1136 .

Description

The PR expands the scope of PEP 8 checks to cover some notebooks there were previously excluded

Checks

  • Notebook runs automatically ./runner --no-run

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@mingxin-zheng mingxin-zheng requested a review from wyli January 4, 2023 10:58
@wyli
Copy link
Contributor

wyli commented Jan 4, 2023

please be careful when fixing the new pep8 issues, there's no automated tests to verify the code changes...

mingxin-zheng and others added 4 commits January 4, 2023 19:52
@mingxin-zheng
Copy link
Contributor Author

mingxin-zheng commented Jan 4, 2023

Hi @wyli , I start to do some manual checks on the notebooks that I touched. The coverage will be limited, and I can see some notebook outside the coverage of our CI/CD is not running correctly, like this one #1139 .

Between fixing the bug in this PR or in another PR, I am inclined to the latter if it is not caused by my changes, so that we can make the PR as atomic as possible.

@wyli
Copy link
Contributor

wyli commented Jan 4, 2023

sure, this looks good to me, if @Nic-Ma doesn't have any other comments let's merge it first.

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Jan 5, 2023

Hi @binliunls @mingxin-zheng ,

Will this PR conflict with #1100?
Just a reminder.

Thanks.

@mingxin-zheng
Copy link
Contributor Author

@binliunls my edits here rearrange some code blocks in video_seg.ipynb to pass PEP 8 checks. If your PR can be merged soon, maybe I can wait and merge yours to mine. The other way also works (merge mine then yours) for me.

@binliunls
Copy link
Contributor

@binliunls my edits here rearrange some code blocks in video_seg.ipynb to pass PEP 8 checks. If your PR can be merged soon, maybe I can wait and merge yours to mine. The other way also works (merge mine then yours) for me.

You can merge first. I will then merge your update to my repo.

@mingxin-zheng mingxin-zheng merged commit a4c8563 into Project-MONAI:main Jan 5, 2023
@mingxin-zheng
Copy link
Contributor Author

Thanks @binliunls , I have just merged mine to the main.

@mingxin-zheng mingxin-zheng deleted the pep8-1136 branch January 20, 2023 10:04
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Signed-off-by: Mingxin Zheng
<[email protected]>

Fixes Project-MONAI#1136 .

### Description
The PR expands the scope of PEP 8 checks to cover some notebooks there
were previously excluded

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [x] Notebook runs automatically `./runner --no-run`

Signed-off-by: Mingxin Zheng <[email protected]>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

PEP8 check should be applied to all notebooks
4 participants