Skip to content

1167 fixes protobuf #1171

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jan 17, 2023
Merged

1167 fixes protobuf #1171

merged 7 commits into from
Jan 17, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jan 16, 2023

Fixes #1167

Description

  • pip install ray might upgrade protobuf automatically, but protobuf v4 is not compatible with some versions of pytorch's tensorboard summarywriter

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

wyli added 4 commits January 16, 2023 10:54
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wyli wyli marked this pull request as ready for review January 16, 2023 15:17
Copy link
Contributor

@KumoLiu KumoLiu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should restrict protobuf to version 3.20.1 seems there are other incompatibilities.

tensorboardx 2.5.1 requires protobuf<=3.20.1,>=3.8.0, but you have protobuf 3.20.3 which is incompatible.
onnx 1.12.0 requires protobuf<=3.20.1,>=3.12.2, but you have protobuf 3.20.3 which is incompatible.

Signed-off-by: Wenqi Li <[email protected]>
@wyli
Copy link
Contributor Author

wyli commented Jan 17, 2023

Maybe we should restrict protobuf to version 3.20.1 seems there are other incompatibilities.

tensorboardx 2.5.1 requires protobuf<=3.20.1,>=3.8.0, but you have protobuf 3.20.3 which is incompatible.
onnx 1.12.0 requires protobuf<=3.20.1,>=3.12.2, but you have protobuf 3.20.3 which is incompatible.

thanks I didn't see this, let me test protobuf<4 as well..

@wyli
Copy link
Contributor Author

wyli commented Jan 17, 2023

this works fine with all the integration tests, I'm merging it for now

@wyli wyli merged commit c60dc6d into Project-MONAI:main Jan 17, 2023
@wyli wyli deleted the 1167-fixes-protobuf branch January 17, 2023 15:30
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Fixes Project-MONAI#1167

### Description
- pip install ray might upgrade protobuf automatically, but protobuf v4
is not compatible with some versions of pytorch's tensorboard
summarywriter

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Avoid including large-size files in the PR.
- [ ] Clean up long text outputs from code cells in the notebook.
- [ ] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

Signed-off-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

from torch.utils.tensorboard import SummaryWriter Descriptors cannot not be created directly.
3 participants