-
Notifications
You must be signed in to change notification settings - Fork 739
SSL Tutorial updated as being notebooks #1177
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
SSL Tutorial updated as being notebooks #1177
Conversation
Signed-off-by: Vishwesh Nath <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: Vishwesh Nath <[email protected]>
Signed-off-by: Vishwesh Nath <[email protected]>
Thank you @finalelement for the PR!
|
Signed-off-by: Vishwesh Nath <[email protected]>
@mingxin-zheng I've tried addressing all the comments. Please see if there is anything more that I can do from my side. |
The comments above should fix these relevant check failures in
But there are some errors in
|
Because the SSL notebooks are created in this PR, the notebook list in |
Addressed all comments again, lets see if the tests work out this time. |
Signed-off-by: Vishwesh Nath <[email protected]>
for more information, see https://pre-commit.ci
The 2 failing tests are from other prior notebooks. Let me know if more changes are needed to the SSL notebooks. |
Thank you @finalelement . It looks good to me! |
Signed-off-by: Vishwesh Nath <[email protected]> Converts the python scripts to being jupyter notebooks that are reflected in MONAI Toolkit. Signed-off-by: Vishwesh Nath <[email protected]> Co-authored-by: Vishwesh Nath <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Signed-off-by: Vishwesh Nath [email protected]
Converts the python scripts to being jupyter notebooks that are reflected in MONAI Toolkit.