Skip to content

Update notebooks of acceleration and performance #1179

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 14 commits into from
Jan 20, 2023

Conversation

dongyang0122
Copy link
Collaborator

Update notebooks of acceleration and performance.

Description

Update notebooks of acceleration and performance.

acceleration/automatic_mixed_precision.ipynb
acceleration/dataset_type_performance.ipynb
acceleration/fast_training_tutorial.ipynb

performance_profiling

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

dongy added 2 commits January 17, 2023 23:43
Signed-off-by: dongy <[email protected]>
Signed-off-by: dongy <[email protected]>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

Copy link
Contributor

@mingxin-zheng mingxin-zheng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As mentioned above, dataset_type_performance and fast_training_tutorial notebooks also have the following issues:

  • Copyright needs to match the guidline template
  • Colab links shouldn't be removed
  • "## Check environment" should be "## Setup Environment"
  • the pip install shell commands should be there, and the nvidia-smi should be removed.

Thanks!

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Jan 18, 2023

Hi @dongyang0122 ,

Could you please help also update the guide document as all the related content are updated to A100?
https://github.com/Project-MONAI/tutorials/blob/main/acceleration/fast_model_training_guide.md

Thanks in advance.

@dongyang0122
Copy link
Collaborator Author

Hi @dongyang0122 ,

Could you please help also update the guide document as all the related content are updated to A100? https://github.com/Project-MONAI/tutorials/blob/main/acceleration/fast_model_training_guide.md

Thanks in advance.

@Nic-Ma sure, I am working on it now.

Signed-off-by: dongyang0122 <[email protected]>
Signed-off-by: dongyang0122 <[email protected]>
Signed-off-by: dongyang0122 <[email protected]>
Signed-off-by: dongyang0122 <[email protected]>
@mingxin-zheng
Copy link
Contributor

mingxin-zheng commented Jan 20, 2023

Hi @dongyang0122 , there is a minor error that needs to be fixed. Everything else looks good to me:

Running ./acceleration/automatic_mixed_precision.ipynb
Checking PEP8 compliance...
stdin:462:1: E305 expected 2 blank lines after class or function definition, found 1
plt.set_loglevel('WARNING')
^
Error: Try running with autofixes: --autofix.

Check failed!

Update: I pushed a small commit to add the extra blank line in 99bd068.

Signed-off-by: Mingxin Zheng <[email protected]>
@mingxin-zheng mingxin-zheng enabled auto-merge (squash) January 20, 2023 06:17
@dongyang0122
Copy link
Collaborator Author

Hi @dongyang0122 ,
Could you please help also update the guide document as all the related content are updated to A100? https://github.com/Project-MONAI/tutorials/blob/main/acceleration/fast_model_training_guide.md
Thanks in advance.

@Nic-Ma sure, I am working on it now.

Hi @Nic-Ma, I have updated the guide document with A100 results.

dongy and others added 3 commits January 19, 2023 22:47
Signed-off-by: dongy <[email protected]>
Signed-off-by: dongyang0122 <[email protected]>
Signed-off-by: dongyang0122 <[email protected]>
@mingxin-zheng mingxin-zheng merged commit bb33315 into Project-MONAI:main Jan 20, 2023
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Update notebooks of acceleration and performance.

### Description
Update notebooks of acceleration and performance.

acceleration/automatic_mixed_precision.ipynb
acceleration/dataset_type_performance.ipynb
acceleration/fast_training_tutorial.ipynb

performance_profiling

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Avoid including large-size files in the PR.
- [ ] Clean up long text outputs from code cells in the notebook.
- [ ] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

Signed-off-by: dongy <[email protected]>
Signed-off-by: dongyang0122 <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Co-authored-by: dongy <[email protected]>
Co-authored-by: Mingxin Zheng <[email protected]>
Co-authored-by: Mingxin Zheng <[email protected]>
@dongyang0122 dongyang0122 deleted the update_acceleration branch August 22, 2024 22:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants