-
Notifications
You must be signed in to change notification settings - Fork 739
Fix copyright and guidelines test errors for remaining tutorials #1182
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
mingxin-zheng
merged 7 commits into
Project-MONAI:main
from
mingxin-zheng:fix-1181-tests
Jan 21, 2023
Merged
Fix copyright and guidelines test errors for remaining tutorials #1182
mingxin-zheng
merged 7 commits into
Project-MONAI:main
from
mingxin-zheng:fix-1181-tests
Jan 21, 2023
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
Signed-off-by: Mingxin Zheng <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Mingxin Zheng <[email protected]>
KumoLiu
approved these changes
Jan 21, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for update, looks good to me.
binliunls
approved these changes
Jan 21, 2023
5 tasks
boneseva
pushed a commit
to boneseva/MONAI-tutorials
that referenced
this pull request
Apr 21, 2024
…ject-MONAI#1182) Fixes Project-MONAI#1181 . ### Description - Update the guideline test to avoid counting line returns in non-text outputs (for example, html data) - Add copyright for all remaining scripts and clean replicates of old copyright info in the following notebooks - 2d_classification\mednist_tutorial.ipynb - 2d_registration\registration_mednist.ipynb - 3d_classification\densenet_training_array.ipynb - acceleration\multi_gpu_test.ipynb - acceleration\threadbuffer_performance.ipynb - acceleration\transform_speed.ipynb - modules\TorchIO_MONAI_PyTorch_Lightning.ipynb - modules\UNet_input_size_constrains.ipynb - multimodal\openi_multilabel_classification_transchex\transchex_openi_multilabel_classification.ipynb - experiment_management\spleen_segmentation_aim.ipynb - experiment_management\spleen_segmentation_mlflow.ipynb - Fix markdown cells for notebooks to match guidelines - experiment_management\bundle_integrate_mlflow.ipynb - modules\resample_benchmark.ipynb - Update the outputs in the following notebooks: - 2d_classification\mednist_tutorial.ipynb - 2d_registration\registration_mednist.ipynb - 3d_classification\densenet_training_array.ipynb ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Avoid including large-size files in the PR. - [x] Clean up long text outputs from code cells in the notebook. - [x] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [x] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` Signed-off-by: Mingxin Zheng <[email protected]> Signed-off-by: Mingxin Zheng <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1181 .
Description
Update the guideline test to avoid counting line returns in non-text outputs (for example, html data)
Add copyright for all remaining scripts and clean replicates of old copyright info in the following notebooks
Fix markdown cells for notebooks to match guidelines
Update the outputs in the following notebooks:
Checks
./figure
folder./runner.sh -t <path to .ipynb file>