Skip to content

1191 fixes deprecated args #1192

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 27, 2023
Merged

1191 fixes deprecated args #1192

merged 2 commits into from
Jan 27, 2023

Conversation

wyli
Copy link
Contributor

@wyli wyli commented Jan 27, 2023

Signed-off-by: Wenqi Li [email protected]

Fixes #1191

Description

dimensions -> spatial_dims

see also
https://github.com/Project-MONAI/MONAI/pull/5901/files#diff-de1bb0722a11b59358d44127ab828343ddd49e2b0478ff9f9d07e96a6f91c5de

Checks

  • Avoid including large-size files in the PR.
  • Clean up long text outputs from code cells in the notebook.
  • For security purposes, please check the contents and remove any sensitive info such as user names and private key.
  • Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the ./figure folder
  • Notebook runs automatically ./runner.sh -t <path to .ipynb file>

Signed-off-by: Wenqi Li <[email protected]>
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@wyli wyli merged commit 56ba738 into Project-MONAI:main Jan 27, 2023
@wyli wyli deleted the 1191-spatial-dims branch January 27, 2023 12:51
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@wyli Could you please help also confirm the tutorials repo?

Thanks in advance.

boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
Signed-off-by: Wenqi Li <[email protected]>

Fixes Project-MONAI#1191

### Description
dimensions -> spatial_dims

see also

https://github.com/Project-MONAI/MONAI/pull/5901/files#diff-de1bb0722a11b59358d44127ab828343ddd49e2b0478ff9f9d07e96a6f91c5de

### Checks
<!--- Put an `x` in all the boxes that apply, and remove the not
applicable items -->
- [ ] Avoid including large-size files in the PR.
- [ ] Clean up long text outputs from code cells in the notebook.
- [ ] For security purposes, please check the contents and remove any
sensitive info such as user names and private key.
- [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use
relative paths for tutorial repo files (3) put figure and graphs in the
`./figure` folder
- [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>`

Signed-off-by: Wenqi Li <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

test error: deepgrow/ignite/inference_3d.ipynb
3 participants