-
Notifications
You must be signed in to change notification settings - Fork 739
config cachedatset for dataset_type_performance #1220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Wenqi Li <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: Wenqi Li <[email protected]>
Hi @wyli , May I know the root cause of the performance issue? Why Thanks. |
Yes, the root cause is the cache init being slow, and maybe related to Project-MONAI/MONAI#5930. image_only will remove the additional unnecessary meta_dict and the warning message. It doesn't change the relative speed comparisons. We should keep cache_init, because the cache dataset still have the option of precompute the cache, the user can experiment and plot. |
OK, could you please help add some description or comment in the notebook to explain the "runtime_cache" usage and Thanks in advance. |
578fc59
to
70319f0
Compare
Signed-off-by: Wenqi Li <[email protected]>
70319f0
to
1a808ea
Compare
for more information, see https://pre-commit.ci
Signed-off-by: Wenqi Li <[email protected]>
If |
Signed-off-by: Wenqi Li <[email protected]>
Signed-off-by: Wenqi Li <[email protected]>
Fixes Project-MONAI#1214 ### Description update the cachedatset config to improve the performance ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [x] Avoid including large-size files in the PR. - [x] Clean up long text outputs from code cells in the notebook. - [x] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [x] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [x] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: Wenqi Li <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Fixes #1214
Description
update the cachedatset config to improve the performance
Checks
./figure
folder./runner.sh -t <path to .ipynb file>