Add maisi controlnet training #1750
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
guopengf
force-pushed
the
add-maisi-controlnet-training
branch
from
252d686 to
5884e19
Compare
Signed-off-by: Pengfei Guo <[email protected]>
Signed-off-by: Pengfei Guo <[email protected]>
for more information, see https://pre-commit.ci Signed-off-by: Pengfei Guo <[email protected]>
### Description This updates the two example scripts which used old code MONAI no long has. ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [ ] Avoid including large-size files in the PR. - [ ] Clean up long text outputs from code cells in the notebook. - [ ] For security purposes, please check the contents and remove any sensitive info such as user names and private key. - [ ] Ensure (1) hyperlinks and markdown anchors are working (2) use relative paths for tutorial repo files (3) put figure and graphs in the `./figure` folder - [ ] Notebook runs automatically `./runner.sh -t <path to .ipynb file>` --------- Signed-off-by: Eric Kerfoot <[email protected]> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Co-authored-by: YunLiu <[email protected]> Signed-off-by: Pengfei Guo <[email protected]>
<!--pre-commit.ci start--> updates: - [github.com/pre-commit/pre-commit-hooks: v4.5.0 → v4.6.0](pre-commit/pre-commit-hooks@v4.5.0...v4.6.0) - [github.com/psf/black: 24.3.0 → 24.4.2](psf/black@24.3.0...24.4.2) <!--pre-commit.ci end--> Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com> Signed-off-by: Pengfei Guo <[email protected]>
Signed-off-by: Pengfei Guo <[email protected]>
guopengf
force-pushed
the
add-maisi-controlnet-training
branch
from
5884e19 to
3295944
Compare
Signed-off-by: Pengfei Guo <[email protected]>
Signed-off-by: Pengfei Guo <[email protected]>
for more information, see https://pre-commit.ci
|
Hi @guopengf , can we have some doc-string added in the functions? Thanks! |
Signed-off-by: Pengfei Guo <[email protected]>
Signed-off-by: Pengfei Guo <[email protected]>
Hi @mingxin-zheng, thanks for the comments. I added docstring for util functions. |
for more information, see https://pre-commit.ci
Signed-off-by: Pengfei Guo <[email protected]>
|
@KumoLiu I don't have any further comments except the ones above. |
KumoLiu
reviewed
Jul 5, 2024
Co-authored-by: Mingxin Zheng <[email protected]> Signed-off-by: Pengfei Guo <[email protected]>
Signed-off-by: Pengfei Guo <[email protected]>
for more information, see https://pre-commit.ci
|
Hi @KumoLiu and @mingxin-zheng, thanks for the valuable comments! I addressed them in the latest commit. In addition, I moved utility functions used in the controlnet training script to scripts/utils.py since I found Can's PR has been merged. |
mingxin-zheng
approved these changes
Jul 8, 2024
KumoLiu
reviewed
Jul 8, 2024
Co-authored-by: YunLiu <[email protected]> Signed-off-by: Pengfei Guo <[email protected]>
Co-authored-by: YunLiu <[email protected]> Signed-off-by: Pengfei Guo <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes # .
Description
Add training script for MAISI ControlNet.
Checks
./figurefolder./runner.sh -t <path to .ipynb file>