-
Notifications
You must be signed in to change notification settings - Fork 739
change folder name generative to generation #1767
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Can-Zhao <[email protected]>
We've always called it "Generative AI", I think the name makes sense to refer to that term though it differs from many other names in tutorials currently. Was there a particular reason you thought this needed renaming? We should check no URLs get broken by this, eg. Colab links in notebooks. |
I remember there was concern when people import package |
Hi @Can-Zhao, thanks for the pr, please also updated related "Setup environment" section. And @ericspod, yes, just like what Can mentioned, the main issue here is that |
Hi Yun, the |
I know, I mean remove the print statement which is temporarily used to avoid the conflict. |
My understanding then is if someone imports "generative" with the current working directory as the root of this repo, they'll import the directory here "generative" rather than the GenerativeModels module. That seems a valid concern, even though GenerativeModels is going to become archived when the porting process is done it will still be used. I'm good with this change, thanks. |
…into mv_generation
Signed-off-by: Can-Zhao <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: Can Zhao <[email protected]>
Signed-off-by: Can Zhao <[email protected]>
Signed-off-by: Can Zhao <[email protected]>
Done |
Thanks |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm good if others are. Thanks!
Fixes # .
Description
change folder name generative to generation
Checks
./figure
folder./runner.sh -t <path to .ipynb file>