-
Notifications
You must be signed in to change notification settings - Fork 739
Refactor MAISI tutorial, migrate GenerativeAI import #1779
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: Can-Zhao <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
MR is still in draft state. Maybe there are some more refactors
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Can-Zhao <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Can-Zhao <[email protected]>
…into refactor_maisi
Signed-off-by: Can-Zhao <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Can-Zhao <[email protected]>
…into refactor_maisi
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
…k to save time Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Can-Zhao <[email protected]>
…into refactor_maisi
for more information, see https://pre-commit.ci
To pass CI, it requires monai core ControlNetMaisi to remove generative dependency first. |
It seems we can re-run it after this PR is merged: |
…iption Signed-off-by: Can-Zhao <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: Can-Zhao <[email protected]>
Signed-off-by: Can-Zhao <[email protected]>
…into refactor_maisi
for more information, see https://pre-commit.ci
Signed-off-by: Can-Zhao <[email protected]>
…into refactor_maisi
Signed-off-by: Can-Zhao <[email protected]>
for more information, see https://pre-commit.ci
Hi @Can-Zhao, I find there is still one place need to be updated in the maisi: https://github.com/Project-MONAI/tutorials/blob/main/generation/maisi/configs/config_maisi_diff_model.json#L3 |
Submitted a PR for it #1786 |
Fixes #1772 .
Description
Refactor MAISI tutorial, migrate GenerativeAI import to monai core.
Add inference script.
Correct logging format.
VAE training notebook tested.
Diffusion training notebook tested.
ControlNet training notebook tested.
Inference notebook tested.
Checks
./figure
folder./runner.sh -t <path to .ipynb file>