Skip to content

652 Enhance get_kernels_strides of DynUNet pipeline #653

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Apr 12, 2022

Conversation

yiheng-wang-nv
Copy link
Contributor

@yiheng-wang-nv yiheng-wang-nv commented Apr 11, 2022

Fixes #652 .

Description

Add some doc-strings to describe the requirements of the input size for DynUNet, and for sizes that cannot find suitable strides, an error will be raised. This change is helpful for users that need to use this function for other tasks.

Status

Ready

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

@yiheng-wang-nv yiheng-wang-nv requested review from Nic-Ma and wyli April 11, 2022 06:54
Signed-off-by: Yiheng Wang <[email protected]>
Signed-off-by: Yiheng Wang <[email protected]>
@yiheng-wang-nv yiheng-wang-nv enabled auto-merge (squash) April 12, 2022 15:57
@yiheng-wang-nv yiheng-wang-nv merged commit 5b5533c into master Apr 12, 2022
@yiheng-wang-nv yiheng-wang-nv deleted the add-size-check-for-dynunet branch April 12, 2022 15:59
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
)

* enhance get-kernels-strides

Signed-off-by: Yiheng Wang <[email protected]>

* modify valueerror message

Signed-off-by: Yiheng Wang <[email protected]>

* remove unused var

Signed-off-by: Yiheng Wang <[email protected]>

* change raise msg

Signed-off-by: Yiheng Wang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Enhance DynUNet tutorial via adding input size check
2 participants