Skip to content

Extra saliency #690

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 12, 2022
Merged

Extra saliency #690

merged 7 commits into from
May 12, 2022

Conversation

rijobro
Copy link
Contributor

@rijobro rijobro commented May 6, 2022

Requires Project-MONAI/MONAI#4236.

Status

Ready

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

@rijobro rijobro requested review from wyli, ericspod and Nic-Ma May 6, 2022 11:13
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@review-notebook-app
Copy link

review-notebook-app bot commented May 11, 2022

View / edit / reply to this conversation on ReviewNB

wyli commented on 2022-05-11T13:30:33Z
----------------------------------------------------------------

Line #3.    directory = os.path.join(directory, "CatsAndDogs")

I downloaded the dataset, unzipping it, there is no CatsAndDogs folder, but there is Cat and Dog folders

perhaps remove these checks:

directory = os.path.join(directory, "CatsAndDogs")

assert os.path.isdir(directory)



rijobro commented on 2022-05-12T12:03:11Z
----------------------------------------------------------------

I changed it to use a URL rather than kaggle, so should be automatic.

Copy link
Contributor Author

rijobro commented May 12, 2022

I changed it to use a URL rather than kaggle, so should be automatic.


View entire conversation on ReviewNB

@review-notebook-app
Copy link

View / edit / reply to this conversation on ReviewNB

rijobro commented on 2022-05-12T12:05:34Z
----------------------------------------------------------------

@wyli, @ericspod, @Nic-Ma, could you check this text and let me know if you think anything could be improved upon?


@wyli wyli merged commit d427cd8 into Project-MONAI:master May 12, 2022
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
* TorchIO download data to MONAI_DATA_DIRECTORY

* dogs and cats saliency

* fix

* update

* pep compliance
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants