Skip to content

Update tumor detection pipline with new components #697

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 34 commits into from
Jul 20, 2022

Conversation

bhashemian
Copy link
Member

@bhashemian bhashemian commented May 11, 2022

Fixes #636

Description

Updates the ignite-based tumor detection pipeline that uses numpy and pytorch tensors with the new components in MONAI.

Status

Ready

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
Signed-off-by: Behrooz <[email protected]>
@Nic-Ma
Copy link
Contributor

Nic-Ma commented May 12, 2022

Hi @drbeh ,

Do you also need to update the code under tumor_detection/torch/ folder?

Thanks.

@bhashemian
Copy link
Member Author

Hi @drbeh ,

Do you also need to update the code under tumor_detection/torch/ folder?

Thanks.

Hey @Nic-Ma, yes of course. All the tumor detection tutorials need to be updated.

@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.


Powered by ReviewNB

@bhashemian bhashemian marked this pull request as ready for review May 16, 2022 14:06
@bhashemian bhashemian enabled auto-merge (squash) July 7, 2022 17:37
@bhashemian bhashemian requested a review from Nic-Ma July 7, 2022 17:38
@bhashemian
Copy link
Member Author

@Nic-Ma this pipeline is already tested by @ZiyueXu77 and FROC is maintained (~0.7).

@Nic-Ma
Copy link
Contributor

Nic-Ma commented Jul 8, 2022

Hi @drbeh ,

Could you please help remove the 2 CSV files from the PR? It makes the PR around 200000 lines change.

Thanks.

Signed-off-by: Behrooz <[email protected]>
@bhashemian
Copy link
Member Author

Hi @drbeh ,

Could you please help remove the 2 CSV files from the PR? It makes the PR around 200000 lines change.

Thanks.

Hi @Nic-Ma,
Absolutely! I left them there for Ziyue while we were changing things.

@Nic-Ma Nic-Ma disabled auto-merge July 18, 2022 07:30
Copy link
Contributor

@Nic-Ma Nic-Ma left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the update, looks good to me.
@wyli Do you have any other comments?

Thanks.

@Nic-Ma Nic-Ma merged commit a08b8e0 into Project-MONAI:main Jul 20, 2022
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
* Update tumor detection pipline with new components

Signed-off-by: Behrooz <[email protected]>

* formatting

Signed-off-by: Behrooz <[email protected]>

* formatting

Signed-off-by: Behrooz <[email protected]>

* Add sub dataset

Signed-off-by: Behrooz <[email protected]>

* Convert xxxD transforms to xxxd

Signed-off-by: Behrooz <[email protected]>

* Update pipline with nvtx annotation

Signed-off-by: Behrooz <[email protected]>

* Add transforms to validation

Signed-off-by: Behrooz <[email protected]>

* Update tumor notebook

Signed-off-by: Behrooz <[email protected]>

* Update torch-based pipeline

Signed-off-by: Behrooz <[email protected]>

* Update perfomance profiling code

Signed-off-by: Behrooz <[email protected]>

* Update grid shape

Signed-off-by: Behrooz <[email protected]>

* Update

Signed-off-by: Behrooz <[email protected]>

* Update a comment

Signed-off-by: Behrooz <[email protected]>

* Update training/validation dataset and their links

Signed-off-by: Behrooz <[email protected]>

* Fix image path

Signed-off-by: Behrooz <[email protected]>

* Change to validate by default

Signed-off-by: Behrooz <[email protected]>

* Flip back the location dims

Signed-off-by: Behrooz <[email protected]>

* Add filtered datasets

Signed-off-by: Behrooz <[email protected]>

* Update csv loading

Signed-off-by: Behrooz <[email protected]>

* Update validation defaults

Signed-off-by: Behrooz <[email protected]>

* Remove csv files

Signed-off-by: Behrooz <[email protected]>

Co-authored-by: Nic Ma <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants