Skip to content

[WIP] NuClick Tutorial #739

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Jul 2, 2022
Merged

[WIP] NuClick Tutorial #739

merged 10 commits into from
Jul 2, 2022

Conversation

finalelement
Copy link
Contributor

Signed-off-by: vnath [email protected]

Description

Adding NuClick Tutorial based on upcoming integrations to MONAI Core.

Status

Work in progress

Checks

  • Notebook runs automatically ./runner [-p <regex_pattern>]

@finalelement finalelement marked this pull request as draft May 27, 2022 21:22
@review-notebook-app
Copy link

Check out this pull request on  ReviewNB

See visual diffs & provide feedback on Jupyter Notebooks.

Powered by ReviewNB

@finalelement finalelement marked this pull request as ready for review June 23, 2022 21:25
@finalelement
Copy link
Contributor Author

I think these look reasonable, I can do some more polishing perhaps.

@wyli please check it out

@SachidanandAlle please provide some more thoughts for the visualization of transforms, if we need them.

@SachidanandAlle
Copy link
Contributor

SachidanandAlle commented Jun 23, 2022 •
edited
Loading

for infer it will be nice if

  1. we can show case each pre transform.
  2. infer and output...
  3. each post transfom

in simple words something like deepgrow infer notebook
https://github.com/Project-MONAI/tutorials/blob/main/deepgrow/ignite/inference.ipynb

@finalelement
Copy link
Contributor Author

@SachidanandAlle Thanks, will add the suggested kind of explanation for inference ..

@wyli I'll reach out again after updating Sachi's comments

@finalelement
Copy link
Contributor Author

finalelement commented Jul 1, 2022 •
edited
Loading

@SachidanandAlle please check the changes.

@wyli I ran tests, quite a few fail, reaching out offline

@SachidanandAlle
Copy link
Contributor

LGTM

@finalelement
Copy link
Contributor Author

@wyli all tests cleared, thank you for the support

@finalelement
Copy link
Contributor Author

@wyli nuclick tests excluded from runner.sh as suggested. Links for pre-trained weight has also been added.

wyli
wyli approved these changes Jul 2, 2022
View reviewed changes
Copy link
Contributor

@wyli wyli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it looks good to me.

@wyli wyli enabled auto-merge (squash) July 2, 2022 05:22
@wyli wyli merged commit 2da31b6 into Project-MONAI:main Jul 2, 2022
boneseva pushed a commit to boneseva/MONAI-tutorials that referenced this pull request Apr 21, 2024
@finalelement
[WIP] NuClick Tutorial (Project-MONAI#739)
b5c17e0 
* Rough training code added

Signed-off-by: vnath <[email protected]>

* Training Jupyter Notebook added

Signed-off-by: vnath <[email protected]>

* Infer process needs more work

Signed-off-by: vnath <[email protected]>

* Inference Pipeline Added

Signed-off-by: vnath <[email protected]>

* More polish needed

Signed-off-by: vnath <[email protected]>

* Training & Inference Notebooks Polished, could use a little more comments

Signed-off-by: vnath <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wyli wyli wyli approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@finalelement @SachidanandAlle @wyli