-
Notifications
You must be signed in to change notification settings - Fork 739
HoVerNet training pipeline #999
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Signed-off-by: KumoLiu <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: KumoLiu <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Check out this pull request on See visual diffs & provide feedback on Jupyter Notebooks. Powered by ReviewNB |
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
…into hovernet-train
for more information, see https://pre-commit.ci
Hi @KumoLiu, since we only have ignite based pipelines here, could you please update the name of the files to |
Signed-off-by: KumoLiu <[email protected]>
for more information, see https://pre-commit.ci
Signed-off-by: KumoLiu <[email protected]>
update README Signed-off-by: KumoLiu <[email protected]>
…into hovernet-train
for more information, see https://pre-commit.ci
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Apart from the CV2 comment I made, it looks good.
Signed-off-by: KumoLiu <[email protected]>
Signed-off-by: KumoLiu <[email protected]>
…o hovernet-train
Hi @KumoLiu Thanks for your great work. I have been looking for the best hovernet implementation for my case. However, I have a comment here on using .mat format.https://github.com/KumoLiu/tutorials/blob/1b9f64d3a32fa08d37048dab282bf8e82c84aed7/pathology/hovernet/prepare_patches.py#L20 My WSI is huge and could not be accommodated in .mat format. Also, I find this format to be unintutive to a python user. So, can we replace it with .npy source or wrap it to give a flexiblity to choose the best format? |
Hi @OmarAshkar - Thanks for your interest in Monai and Hovernet. So the .mat format is being used here to load annotations that are part of the ConSep dataset. Each .mat file will contain annotations for the nuclei. There should be no need to present your WSI in .mat format. If you want to run inference on your WSI, you don't need to use this script at all. If you do wish to train Hovernet on your own data, then you would need to prepare the data and annotations in a format of your choosing. You could certainly use .npy for that. Hope that helps. |
Thanks @JHancox! yes I want to train my own data. I really wanted to extract the batches first instead of figuring out how to customize it for hovernet architecture. But I understand I think I will manipulate the script to my taste. Thanks! |
Fixes Project-MONAI/MONAI#4878 ### Description HoVerNet training tutorial - [x] ignite version pipeline ### Checks <!--- Put an `x` in all the boxes that apply, and remove the not applicable items --> - [ ] Notebook runs automatically `./runner [-p <regex_pattern>]` Signed-off-by: KumoLiu <[email protected]>
Fixes Project-MONAI/MONAI#4878
Description
HoVerNet training tutorial
Checks
./runner [-p <regex_pattern>]