Skip to content

Cache Carthage builds on Travis #20

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 10, 2017
Merged

Cache Carthage builds on Travis #20

merged 1 commit into from
Apr 10, 2017

Conversation

1ec5
Copy link
Member

@1ec5 1ec5 commented Apr 9, 2017

Cache Carthage builds on Travis per travis-ci/travis-ci#6348 (comment).

/cc @frederoni

@1ec5 1ec5 added the build label Apr 9, 2017
@1ec5 1ec5 self-assigned this Apr 9, 2017
@1ec5 1ec5 requested a review from frederoni April 9, 2017 17:30
@1ec5
Copy link
Member Author

1ec5 commented Apr 9, 2017 •
edited
Loading

The brew steps add about a minute to the cold build time but shaves about 30 seconds from the warm build time, relative to builds of master. This change uses brew to upgrade Carthage from the preinstalled v0.18.1 to the latest version, because the --cache-builds flag is new to v0.20.0. I’m not sure if we should merge this change now or wait until Travis upgrades its machines to Carthage v0.20.0 or above, in which case we could remove the brew steps.

frederoni
frederoni approved these changes Apr 10, 2017
View reviewed changes
Copy link
Contributor

@frederoni frederoni left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The bundled version is 6 months old and the intermediate upgrade to 0.19 never happened so let's get this merged.

@1ec5 1ec5 merged commit 2f072bf into master Apr 10, 2017
@1ec5 1ec5 deleted the 1ec5-travis-cache branch April 10, 2017 16:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@frederoni frederoni frederoni approved these changes

Assignees

@1ec5 1ec5

Labels
build
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@1ec5 @frederoni