Add phrase lookup method #40
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added a method to look up a phrase format string by name.
bsudekum
reviewed
Sep 15, 2017
| */ | ||
| public func phrase(named name: PhraseName) -> String { | ||
| let phrases = instructions["phrase"] as! [String: String] | ||
| return phrases["\(name)"]! |
There was a problem hiding this comment.
Does it make sense to make this return optional?
There was a problem hiding this comment.
PhraseName is a limited set of values, so if a valid PhraseName is passed in, I think the return value should be required.
bsudekum
approved these changes
Sep 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a method to look up a phrase format string by name. This allows clients to actually use the phrase support that was added in #38.
Also migrated to the Xcode 8.3 project format, since Xcode automatically accepted all its recommendations for some reason.
/cc @bsudekum