-
Notifications
You must be signed in to change notification settings - Fork 66
Add ceremonial name handling #129
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -408,4 +408,4 @@ | |
} | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -399,4 +399,4 @@ | |
} | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -399,4 +399,4 @@ | |
} | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -399,4 +399,4 @@ | |
} | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -399,4 +399,4 @@ | |
} | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -413,4 +413,4 @@ | |
} | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -399,4 +399,4 @@ | |
} | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -399,4 +399,4 @@ | |
} | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -413,4 +413,4 @@ | |
} | ||
} | ||
} | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -284,4 +284,4 @@ | |
} | ||
} | ||
} | ||
} | ||
} |
28 changes: 28 additions & 0 deletions
28
test/fixtures/v5/other/motorway_ref_has_no_number_left.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"step": { | ||
"maneuver": { | ||
"type": "continue", | ||
"modifier": "left" | ||
}, | ||
"name": "Cool highway", | ||
"ref": "Ref no number" | ||
}, | ||
"instructions": { | ||
"de": "Links weiterfahren auf Cool highway", | ||
"en": "Continue left onto Cool highway", | ||
"es": "Continua izquierda en Cool highway", | ||
"fr": "Continuer à gauche sur Cool highway", | ||
"id": "Terus kiri ke Cool highway", | ||
"nl": "Ga links naar Cool highway", | ||
"pl": "Kontynuuj lewo na Cool highway", | ||
"ru": "Двигайтесь налево по Cool highway", | ||
"sv": "Fortsätt vänster in på Cool highway", | ||
"vi": "Chạy tiếp bên trái trên Cool highway", | ||
"zh-Hans": "继续向左,上Cool highway" | ||
}, | ||
"options": { | ||
"classes": [ | ||
"motorway" | ||
] | ||
} | ||
} |
28 changes: 28 additions & 0 deletions
28
test/fixtures/v5/other/motorway_ref_has_no_number_right.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"step": { | ||
"maneuver": { | ||
"type": "continue", | ||
"modifier": "right" | ||
}, | ||
"name": "Cool highway", | ||
"ref": "Ref no number" | ||
}, | ||
"instructions": { | ||
"de": "Rechts weiterfahren auf Cool highway", | ||
"en": "Continue right onto Cool highway", | ||
"es": "Continua derecha en Cool highway", | ||
"fr": "Continuer à droite sur Cool highway", | ||
"id": "Terus kanan ke Cool highway", | ||
"nl": "Ga rechts naar Cool highway", | ||
"pl": "Kontynuuj prawo na Cool highway", | ||
"ru": "Двигайтесь направо по Cool highway", | ||
"sv": "Fortsätt höger in på Cool highway", | ||
"vi": "Chạy tiếp bên phải trên Cool highway", | ||
"zh-Hans": "继续向右,上Cool highway" | ||
}, | ||
"options": { | ||
"classes": [ | ||
"motorway" | ||
] | ||
} | ||
} |
28 changes: 28 additions & 0 deletions
28
test/fixtures/v5/other/motorway_ref_has_no_number_sharp left.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"step": { | ||
"maneuver": { | ||
"type": "continue", | ||
"modifier": "sharp left" | ||
}, | ||
"name": "Cool highway", | ||
"ref": "Ref no number" | ||
}, | ||
"instructions": { | ||
"de": "Scharf links weiterfahren auf Cool highway", | ||
"en": "Continue sharp left onto Cool highway", | ||
"es": "Continua cerrada a la izquierda en Cool highway", | ||
"fr": "Continuer franchement à gauche sur Cool highway", | ||
"id": "Terus tajam kiri ke Cool highway", | ||
"nl": "Ga linksaf naar Cool highway", | ||
"pl": "Kontynuuj ostro w lewo na Cool highway", | ||
"ru": "Двигайтесь налево по Cool highway", | ||
"sv": "Fortsätt skarp vänster in på Cool highway", | ||
"vi": "Chạy tiếp bên trái gắt trên Cool highway", | ||
"zh-Hans": "继续向左,上Cool highway" | ||
}, | ||
"options": { | ||
"classes": [ | ||
"motorway" | ||
] | ||
} | ||
} |
28 changes: 28 additions & 0 deletions
28
test/fixtures/v5/other/motorway_ref_has_no_number_sharp right.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"step": { | ||
"maneuver": { | ||
"type": "continue", | ||
"modifier": "sharp right" | ||
}, | ||
"name": "Cool highway", | ||
"ref": "Ref no number" | ||
}, | ||
"instructions": { | ||
"de": "Scharf rechts weiterfahren auf Cool highway", | ||
"en": "Continue sharp right onto Cool highway", | ||
"es": "Continua cerrada a la derecha en Cool highway", | ||
"fr": "Continuer franchement à droite sur Cool highway", | ||
"id": "Terus tajam kanan ke Cool highway", | ||
"nl": "Ga rechtsaf naar Cool highway", | ||
"pl": "Kontynuuj ostro w prawo na Cool highway", | ||
"ru": "Двигайтесь направо по Cool highway", | ||
"sv": "Fortsätt skarp höger in på Cool highway", | ||
"vi": "Chạy tiếp bên phải gắt trên Cool highway", | ||
"zh-Hans": "继续向右,上Cool highway" | ||
}, | ||
"options": { | ||
"classes": [ | ||
"motorway" | ||
] | ||
} | ||
} |
28 changes: 28 additions & 0 deletions
28
test/fixtures/v5/other/motorway_ref_has_no_number_slight left.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"step": { | ||
"maneuver": { | ||
"type": "continue", | ||
"modifier": "slight left" | ||
}, | ||
"name": "Cool highway", | ||
"ref": "Ref no number" | ||
}, | ||
"instructions": { | ||
"de": "Leicht links weiter auf Cool highway", | ||
"en": "Continue slightly left onto Cool highway", | ||
"es": "Continua ligeramente a la izquierda en Cool highway", | ||
"fr": "Continuer légèrement à gauche sur Cool highway", | ||
"id": "Tetap agak di kiri ke Cool highway", | ||
"nl": "Links aanhouden naar Cool highway", | ||
"pl": "Kontynuuj łagodnie w lewo na Cool highway", | ||
"ru": "Плавно поверните налево на Cool highway", | ||
"sv": "Fortsätt med lätt vänstersväng in på Cool highway", | ||
"vi": "Nghiêng về bên trái vào Cool highway", | ||
"zh-Hans": "继续向左,上Cool highway" | ||
}, | ||
"options": { | ||
"classes": [ | ||
"motorway" | ||
] | ||
} | ||
} |
28 changes: 28 additions & 0 deletions
28
test/fixtures/v5/other/motorway_ref_has_no_number_slight right.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"step": { | ||
"maneuver": { | ||
"type": "continue", | ||
"modifier": "slight right" | ||
}, | ||
"name": "Cool highway", | ||
"ref": "Ref no number" | ||
}, | ||
"instructions": { | ||
"de": "Leicht rechts weiter auf Cool highway", | ||
"en": "Continue slightly right onto Cool highway", | ||
"es": "Continua ligeramente a la derecha en Cool highway", | ||
"fr": "Continuer légèrement à droite sur Cool highway", | ||
"id": "Tetap agak di kanan ke Cool highway", | ||
"nl": "Rechts aanhouden naar Cool highway", | ||
"pl": "Kontynuuj łagodnie w prawo na Cool highway", | ||
"ru": "Плавно поверните направо на Cool highway", | ||
"sv": "Fortsätt med lätt högersväng in på Cool highway", | ||
"vi": "Nghiêng về bên phải vào Cool highway", | ||
"zh-Hans": "继续向右,上Cool highway" | ||
}, | ||
"options": { | ||
"classes": [ | ||
"motorway" | ||
] | ||
} | ||
} |
28 changes: 28 additions & 0 deletions
28
test/fixtures/v5/other/motorway_ref_has_no_number_straight.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"step": { | ||
"maneuver": { | ||
"type": "continue", | ||
"modifier": "straight" | ||
}, | ||
"name": "Cool highway", | ||
"ref": "Ref no number" | ||
}, | ||
"instructions": { | ||
"de": "Geradeaus weiterfahren auf Cool highway", | ||
"en": "Continue onto Cool highway", | ||
"es": "Continua en Cool highway", | ||
"fr": "Continuer tout droit sur Cool highway", | ||
"id": "Terus ke Cool highway", | ||
"nl": "Ga rechtdoor naar Cool highway", | ||
"pl": "Kontynuuj na Cool highway", | ||
"ru": "Продолжите движение по Cool highway", | ||
"sv": "Fortsätt in på Cool highway", | ||
"vi": "Chạy tiếp trên Cool highway", | ||
"zh-Hans": "继续直行,上Cool highway" | ||
}, | ||
"options": { | ||
"classes": [ | ||
"motorway" | ||
] | ||
} | ||
} |
28 changes: 28 additions & 0 deletions
28
test/fixtures/v5/other/motorway_ref_has_no_number_uturn.json
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"step": { | ||
"maneuver": { | ||
"type": "continue", | ||
"modifier": "uturn" | ||
}, | ||
"name": "Cool highway", | ||
"ref": "Ref no number" | ||
}, | ||
"instructions": { | ||
"de": "180°-Wendung auf Cool highway", | ||
"en": "Make a U-turn onto Cool highway", | ||
"es": "Haz un cambio de sentido en Cool highway", | ||
"fr": "Faire demi-tour sur Cool highway", | ||
"id": "Putar balik ke arah Cool highway", | ||
"nl": "Keer om naar Cool highway", | ||
"pl": "Zawróć na Cool highway", | ||
"ru": "Развернитесь на Cool highway", | ||
"sv": "Gör en U-sväng in på Cool highway", | ||
"vi": "Quẹo ngược lại Cool highway", | ||
"zh-Hans": "调头上Cool highway" | ||
}, | ||
"options": { | ||
"classes": [ | ||
"motorway" | ||
] | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"step": { | ||
"maneuver": { | ||
"type": "continue", | ||
"modifier": "left" | ||
}, | ||
"name": "Cool highway", | ||
"ref": "Ref1;Ref2" | ||
}, | ||
"instructions": { | ||
"de": "Links weiterfahren auf Ref1", | ||
"en": "Continue left onto Ref1", | ||
"es": "Continua izquierda en Ref1", | ||
"fr": "Continuer à gauche sur Ref1", | ||
"id": "Terus kiri ke Ref1", | ||
"nl": "Ga links naar Ref1", | ||
"pl": "Kontynuuj lewo na Ref1", | ||
"ru": "Двигайтесь налево по Ref1", | ||
"sv": "Fortsätt vänster in på Ref1", | ||
"vi": "Chạy tiếp bên trái trên Ref1", | ||
"zh-Hans": "继续向左,上Ref1" | ||
}, | ||
"options": { | ||
"classes": [ | ||
"motorway" | ||
] | ||
} | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
{ | ||
"step": { | ||
"maneuver": { | ||
"type": "continue", | ||
"modifier": "right" | ||
}, | ||
"name": "Cool highway", | ||
"ref": "Ref1;Ref2" | ||
}, | ||
"instructions": { | ||
"de": "Rechts weiterfahren auf Ref1", | ||
"en": "Continue right onto Ref1", | ||
"es": "Continua derecha en Ref1", | ||
"fr": "Continuer à droite sur Ref1", | ||
"id": "Terus kanan ke Ref1", | ||
"nl": "Ga rechts naar Ref1", | ||
"pl": "Kontynuuj prawo na Ref1", | ||
"ru": "Двигайтесь направо по Ref1", | ||
"sv": "Fortsätt höger in på Ref1", | ||
"vi": "Chạy tiếp bên phải trên Ref1", | ||
"zh-Hans": "继续向右,上Ref1" | ||
}, | ||
"options": { | ||
"classes": [ | ||
"motorway" | ||
] | ||
} | ||
} |
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nit: drop the extra parentheses around the regular expression.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The linter for this project actually requires them 😅