Skip to content

Respect locale when capitalizing #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 25, 2017
Merged

Respect locale when capitalizing #164

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -11,8 +11,8 @@ module.exports = function(version, _options) {
});

return {
capitalizeFirstLetter: function(string) {
return string.charAt(0).toUpperCase() + string.slice(1);
capitalizeFirstLetter: function(language, string) {
return string.charAt(0).toLocaleUpperCase(language) + string.slice(1);
},
ordinalize: function(language, number) {
// Transform numbers to their translated ordinalized value
Expand Down Expand Up @@ -206,7 +206,7 @@ module.exports = function(version, _options) {
.replace(/ {2}/g, ' '); // remove excess spaces

if (instructions[language].meta.capitalizeFirstLetter) {
return this.capitalizeFirstLetter(output);
return this.capitalizeFirstLetter(language, output);
}

return output;
Expand Down