Skip to content

Fix pyproject.toml #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Mar 16, 2023
Merged

Fix pyproject.toml #79

merged 1 commit into from
Mar 16, 2023

Conversation

larryliu0820
Copy link
Contributor

Include both files and subdirectory under torch_np.

Include both files and subdirectory under `torch_np`.
@honno
Copy link
Contributor

honno commented Mar 8, 2023

Weird, yeah the previous pyproject won't build the files directly under torch_np/ for the wheel, but will for the tarball (when using python -m build). LGTM

@larryliu0820 out of curiousity, why would one include a setup.py if using pyproject.toml?

@larryliu0820
Copy link
Contributor Author

Weird, yeah the previous pyproject won't build the files directly under torch_np/ for the wheel, but will for the tarball (when using python -m build). LGTM

@larryliu0820 out of curiousity, why would one include a setup.py if using pyproject.toml?

Yeah pyproject.toml is still in beta, for some old environment it may not recognize so need a dummy setup.py.

@larryliu0820
Copy link
Contributor Author

@honno can you please help merge this? I don't have access.

@honno
Copy link
Contributor

honno commented Mar 16, 2023

Trivial change that's nice to get in, so merging.

Yeah pyproject.toml is still in beta, for some old environment it may not recognize so need a dummy setup.py.

Makes sense!

@honno honno merged commit 89a28ec into Quansight-Labs:main Mar 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants