Skip to content

[FIX] Fixes for nbconvert > 6 #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

AakashGfude
Copy link
Member

@AakashGfude AakashGfude commented Jan 5, 2021

This PR solves the following:

The reason behind these till now has been identified as the major release of nbconvert which is 6.0.x

fixes QuantEcon/lecture-python#329

@AakashGfude AakashGfude changed the title [FIX] Reading template file for nbconvert > 6 [FIX] Fixes for nbconvert > 6 Jan 5, 2021
@AakashGfude AakashGfude requested a review from mmcky January 5, 2021 06:46
@mmcky
Copy link
Contributor

mmcky commented Jan 5, 2021

thanks @AakashGfude are there still issues with the tplx?

Can you work through the travis build to get his passing CI

  1. pin sphinxcontrib-bibtex==1.0 should fix this.
  2. Raise an issue for sphinxcontrib-bibtex>=2 compatibility

@AakashGfude
Copy link
Member Author

thanks @AakashGfude are there still issues with the tplx?

Yes, there have been quite drastic changes in nbconvert 6 with regards to templates. I Will have to do edits/refactor on the template files. Doing that at the moment

  1. pin sphinxcontrib-bibtex==1.0 should fix this.
  2. Raise an issue for sphinxcontrib-bibtex>=2 compatibility

Thanks @mmcky . Will do this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants