-
Notifications
You must be signed in to change notification settings - Fork 17
initial code for changing the language #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I believe we can not listen for changes on the There is here an example of how to use the settings that could be useful. And this is the |
Hi @DenisaCG the PR looks great! |
Successfully listening for changes in language using the settings, but still have to add the logic for transmitting the language name further as a parameter for Blockly to be able to change its language as well. Setting another language in Blockly, doesn't change the names of the categories to the respective language.
2f688f4
to
43b27cc
Compare
Thank you for the great feedback and help @hbcarlos! As a wrap-up, in jupyterlab-blockly/src/index.ts Lines 120 to 144 in d56ccaf
Further, in jupyterlab-blockly/src/manager.ts Lines 68 to 183 in d56ccaf
|
The PR is missing the logic for listening to language changes, in Jupyter Lab.
It also mentions this issue, in connection with the error for using the setLocale property from Blockly.