Skip to content

Update organisation -> organization #147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 4, 2024
Merged

Conversation

jtpio
Copy link
Member

@jtpio jtpio commented Sep 3, 2024

Part of #145

Copy link

vercel bot commented Sep 3, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
quantstack-github-io ✅ Ready (Inspect) Visit Preview 💬 Add feedback Sep 3, 2024 5:14pm

@jtpio jtpio marked this pull request as ready for review September 3, 2024 16:47
Copy link
Member

@arjxn-py arjxn-py left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @jtpio, Thanks.
There are some more similar instances, listing them here just for further reference:

@jtpio
Copy link
Member Author

jtpio commented Sep 3, 2024

Thanks @arjxn-py 👍

I pushed a new commit to fix other occurrences for that word, but maybe we could run a spell checker on the whole repo to find other typos more easily.

@arjxn-py
Copy link
Member

arjxn-py commented Sep 3, 2024

Would a pre-commit hook like codespell-project/codespell help?

@jtpio
Copy link
Member Author

jtpio commented Sep 3, 2024

Something like that yes. A hook could be useful, but a one-shot pass could be a good starting point too.

@arjxn-py
Copy link
Member

arjxn-py commented Sep 4, 2024

Something like that yes. A hook could be useful, but a one-shot pass could be a good starting point too.

Thanks for validating :)
As far as I recall, first pre-commit run should be able to do a one shot pass.
In my opinion it should be worth trying on a PR and see if it's effective and feasible.
I'd be more than happy to assist for the same. I could try opening one and iterate over it :)

@jtpio
Copy link
Member Author

jtpio commented Sep 4, 2024

I'd be more than happy to assist for the same. I could try opening one and iterate over it :)

Sure, feel free to open a PR, thanks!

@SylvainCorlay
Copy link
Member

LGTM.

@SylvainCorlay SylvainCorlay merged commit 033c7d9 into QuantStack:master Sep 4, 2024
4 checks passed
@jtpio jtpio deleted the fix branch September 4, 2024 13:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants