remove jQuery or Zepto dependency #173
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minify quickblox.min.js
dimaspirit
reviewed
Nov 20, 2016
| }, function (err, compiledContent) { | ||
| if (err) return console.error(err); | ||
| fs.writeFile('./src/plugins/jquery.ajax.js', compiledContent, function (err) { | ||
| if (err) return console.error(err); |
There was a problem hiding this comment.
Also use notify for notify module about a crash process.
|
We are using npm commands. Like |
|
plus + |
dimaspirit
reviewed
Nov 23, 2016
| @@ -74,7 +77,7 @@ | |||
| "scripts": { | |||
| "setDependencies": "npm i && npm install -g gulp-cli && npm install -g jasmine", | |||
| "lint": "jshint src --reporter=node_modules/jshint-stylish", | |||
| "build": "npm run lint && gulp generate-build_version && gulp build", | |||
| "build": "npm run lint && gulp generate-build_version && gulp build_min", | |||
There was a problem hiding this comment.
You need to build and minify. Like this "build": "npm run lint && gulp generate-build_version && gulp build && gulp minify"
dimaspirit
reviewed
Nov 23, 2016
| gulp.task('watch', function () { | ||
| gulp.watch(['./src/**/*.js'], ['build']); | ||
| }); | ||
|
|
||
| gulp.task('default', ['build', 'connect', 'watch']); | ||
| gulp.task('default', ['build_sdk', 'connect', 'watch']); |
There was a problem hiding this comment.
Where are you find the task build_sdk?
dimaspirit
added a commit
that referenced
this pull request
Nov 30, 2016
* rename qbRecorder to qbMediaRecorder * Add version and build version (#174) Make the property QB.version public; Added the property QB.versionBuild, also as public; Added the gulp generate-build_version task and added in npm run build; Show in samples (chat, webrtc) v.{version}.{versionBuild}; * remove jQuery or Zepto dependency (#173) * add a jquery.ajax as plugin * upd build version * Added JSDOC (API Refference) * Fix firefox WebRTC bugs (#178) * Upd Recorder (changed to qbMediaRecorder module) (#179) * Fixed bug (remove QB.Recorder) * remove QB.Recorder * upd recorder * upd npm install rimraf -g * final build * upd version
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.