Skip to content

Dev.xmpp_client_connection #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 9 commits into from
Mar 26, 2018
Merged

Dev.xmpp_client_connection #320

merged 9 commits into from
Mar 26, 2018

Conversation

Vladlukhanin
Copy link
Contributor

@Vladlukhanin Vladlukhanin commented Mar 20, 2018 •
edited
Loading

NativeScript:

  • Fixed error with method qbUtils.getOS() for NativeScript environment;

node-xmpp-client/nativescript-xmpp-clien:

  • QB.chat.connect() - params.connectWithoutGettingRoster was removed (really for the strophe.js client);
  • QB.chat.connect() can be called twice or more (will return a roster as response);
  • QB.chat.isConnected will return existed state of the chat connection (true/false);
  • An event 'disconnect' will clean all chat's connection listeners.

dimaspirit
dimaspirit reviewed Mar 21, 2018
View reviewed changes
src/modules/chat/qbChat.js Outdated
callback(null, self.roster.contacts);
});
}
// get the roster and save
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

comment without meaning

@Vladlukhanin Vladlukhanin merged commit 2340a17 into dev Mar 26, 2018
@soulfly soulfly removed their request for review March 27, 2018 08:02
@soulfly
Copy link
Contributor

soulfly commented Mar 27, 2018

Looks good for me, please verify that all tests are passed

@sshaforenkoqb sshaforenkoqb deleted the dev.xmpp-client-connection branch July 1, 2019 12:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dimaspirit dimaspirit dimaspirit approved these changes

Assignees

@Vladlukhanin Vladlukhanin

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Vladlukhanin @soulfly @dimaspirit