Add TODO reminder comment

b-sumner · b-sumner · commit 0af67a7ebcfc · 2024-07-26T12:27:23.000-07:00
Change-Id: I52c90c03eddf4d3604aaf76a15c25f0e3f2677a0
diff --git a/compiler-rt/lib/asan/asan_errors.cpp b/compiler-rt/lib/asan/asan_errors.cpp
@@ -754,6 +754,9 @@ void ErrorNonSelfAMDGPU::PrintMallocStack() {
               d.Location(), device_address[0],
               (int)(device_address[0] - (plo+offset)),
               d.Allocation(), ((int*)plo)[7], d.Default());
+      // TODO: The code object with the malloc call may not be the same
+      // code object trying the illegal access.  A mechanism is needed
+      // to obtain the former.
       PrintStack();
     }
 

Original file line number	Diff line number	Diff line change
`@@ -754,6 +754,9 @@ void ErrorNonSelfAMDGPU::PrintMallocStack() {`
`754`	`754`	`d.Location(), device_address[0],`
`755`	`755`	`(int)(device_address[0] - (plo+offset)),`
`756`	`756`	`d.Allocation(), ((int*)plo)[7], d.Default());`
	`757`	`+ // TODO: The code object with the malloc call may not be the same`
	`758`	`+ // code object trying the illegal access. A mechanism is needed`
	`759`	`+ // to obtain the former.`
`757`	`760`	`PrintStack();`
`758`	`761`	`}`
`759`	`762`