Skip to content

Fixes CI build script #1350

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 26, 2024
Merged

Fixes CI build script #1350

merged 2 commits into from
Jan 26, 2024

Conversation

xinyazhang
Copy link

Fixes Internal #6882

This is caused by two problems in combination.

  1. CMAKE_PREFIX_PATH was set to /opt/conda/lib even if the pytorch uses a different conda environment to build, say /opt/conda/envs/py_3.9
  2. The code to parse /etc/os-release is incorrect and the distribution info was parsed as PRETTY_Ubuntu instead of Ubuntu. libtinfo will not be linked into the binary due to this flaw. Thus, cpp unit tests failed to build because of missing symbols from libtinfo

@xinyazhang
Fix the parsing of /etc/os-release
0aafb87 
The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.
@xinyazhang
Configurable CMAKE_PREFIX_PATH in CI script.
36615ab
@xinyazhang xinyazhang marked this pull request as ready for review January 22, 2024 19:12
pruthvistony
pruthvistony requested changes Jan 23, 2024
View reviewed changes
@pruthvistony
Copy link
Collaborator

I am ok with CMAKE_PREFIX_PATH changes. Want to trigger a CI build with
rocm6.1_internal_testing+this PR + AOTriton enabled
to confirm.

@pruthvistony
Copy link
Collaborator

Sample build - http://rocm-ci.amd.com/job/mainline-framework-pytorch-2.1-ub22-py3.10-ci/107/

@pruthvistony pruthvistony merged commit 5d5780c into rocm6.1_internal_testing Jan 26, 2024
pruthvistony pushed a commit that referenced this pull request Mar 12, 2024
@xinyazhang @pruthvistony
Fixes CI build script (#1350)
3b6c838 
* Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.

* Configurable CMAKE_PREFIX_PATH in CI script.
pruthvistony pushed a commit that referenced this pull request Mar 12, 2024
@xinyazhang @pruthvistony
Fixes CI build script (#1350)
6bd1ef8 
* Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.

* Configurable CMAKE_PREFIX_PATH in CI script.
xinyazhang added a commit that referenced this pull request Mar 12, 2024
@xinyazhang
Fixes CI build script (#1350)
462c1c5 
1. Configurable CMAKE_PREFIX_PATH in CI script.

CMAKE_PREFIX_PATH should honor $CONDA_PREFIX as described in PyTorch
build instructions.

2. Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.
pytorchmergebot pushed a commit that referenced this pull request Mar 19, 2024
@xinyazhang @pytorchmergebot
Fixes CI build script (#1350)
a31b1f5 
1. Configurable CMAKE_PREFIX_PATH in CI script.

CMAKE_PREFIX_PATH should honor $CONDA_PREFIX as described in PyTorch
build instructions.

2. Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.
pytorchmergebot pushed a commit that referenced this pull request Apr 10, 2024
@xinyazhang @pytorchmergebot
Fixes CI build script (#1350)
387154d 
1. Configurable CMAKE_PREFIX_PATH in CI script.

CMAKE_PREFIX_PATH should honor $CONDA_PREFIX as described in PyTorch
build instructions.

2. Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.
pruthvistony pushed a commit that referenced this pull request Apr 23, 2024
@xinyazhang @pruthvistony
Fixes CI build script (#1350)
434ee5d 
* Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.

* Configurable CMAKE_PREFIX_PATH in CI script.
pytorchmergebot pushed a commit that referenced this pull request Apr 30, 2024
@xinyazhang @pytorchmergebot
Fixes CI build script (#1350)
b99fe94 
1. Configurable CMAKE_PREFIX_PATH in CI script.

CMAKE_PREFIX_PATH should honor $CONDA_PREFIX as described in PyTorch
build instructions.

2. Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.
dnikolaev-amd pushed a commit that referenced this pull request Jun 20, 2024
@xinyazhang @dnikolaev-amd
Fixes CI build script (#1350)
00307cc 
* Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.

* Configurable CMAKE_PREFIX_PATH in CI script.
pruthvistony pushed a commit that referenced this pull request Aug 12, 2024
@xinyazhang @pruthvistony
Fixes CI build script (#1350)
11f9443 
* Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.

* Configurable CMAKE_PREFIX_PATH in CI script.
dnikolaev-amd pushed a commit that referenced this pull request Sep 16, 2024
@xinyazhang @dnikolaev-amd
Fixes CI build script (#1350)
f1f2b4e 
* Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.

* Configurable CMAKE_PREFIX_PATH in CI script.
jithunnair-amd pushed a commit that referenced this pull request Oct 3, 2024
@xinyazhang @jithunnair-amd
Fixes CI build script (#1350)
c24fc59 
* Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.

* Configurable CMAKE_PREFIX_PATH in CI script.
jithunnair-amd pushed a commit that referenced this pull request Oct 11, 2024
@xinyazhang @jithunnair-amd
Fixes CI build script (#1350)
84113c1 
* Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.

* Configurable CMAKE_PREFIX_PATH in CI script.
jithunnair-amd pushed a commit that referenced this pull request Oct 11, 2024
@xinyazhang @jithunnair-amd
Fixes CI build script (#1350)
a66400c 
* Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.

* Configurable CMAKE_PREFIX_PATH in CI script.
jithunnair-amd pushed a commit that referenced this pull request Oct 11, 2024
@xinyazhang @jithunnair-amd
Fixes CI build script (#1350)
89f69e5 
* Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.

* Configurable CMAKE_PREFIX_PATH in CI script.
jithunnair-amd pushed a commit that referenced this pull request Nov 19, 2024
@xinyazhang @jithunnair-amd
Fixes CI build script (#1350)
80df647 
* Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.

* Configurable CMAKE_PREFIX_PATH in CI script.
pruthvistony pushed a commit that referenced this pull request Dec 2, 2024
@xinyazhang @pruthvistony
Fixes CI build script (#1350)
f919b4b 
* Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.

* Configurable CMAKE_PREFIX_PATH in CI script.
pruthvistony pushed a commit that referenced this pull request Dec 21, 2024
@xinyazhang @pruthvistony
Fixes CI build script (#1350)
090d95f 
* Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.

* Configurable CMAKE_PREFIX_PATH in CI script.
dnikolaev-amd pushed a commit that referenced this pull request Apr 17, 2025
@xinyazhang @dnikolaev-amd
Fixes CI build script (#1350)
b94be16 
* Fix the parsing of /etc/os-release

The old code parses OS_DISTRO as 'PRETTY_Ubuntu' on Ubuntu and thus
never links to libtinfo correctly.

* Configurable CMAKE_PREFIX_PATH in CI script.

(cherry picked from commit 090d95f)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeffdaily jeffdaily jeffdaily approved these changes

@pruthvistony pruthvistony pruthvistony approved these changes

@jithunnair-amd jithunnair-amd Awaiting requested review from jithunnair-amd

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@xinyazhang @pruthvistony @jeffdaily