Replace concatenated string with triple quoted string. #279
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is possible to use a triple quoted string and avoid '+'ing all of the strings together.
|
Hey @cousinitt The community version will receive no further commits/updates, so unfortunately this PR will not accepted. |
|
Oh, ok - am I committing to the wrong repo, or is development all in-house at Proton VPN now? |
|
No worries @cousinitt This repo that your commiting to is the community version. The official one hasn't been (as of yet) publicly published on anywhere (ie github, gitlab, etc), but this will happen as soon as the official client is a bit more stable. Either way, since the current official client is written in python, it can be easily inspected. You can find more information here: https://protonvpn.com/blog/linux-vpn-cli-beta/ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is possible to use a triple quoted string and avoid '+'ing all of the strings together.
This is a style issue, my feelings won't be hurt if folks don't like it.
Just let me know and I will delete it to keep clutter down.