feat: add v4's float effect (follow mouse position)
#861
Conversation
|
I believe we really need to give the option to use a fixed tooltip or this one, both situations are for different use cases. Also, do you know if for float option is there a way to not let the arrow corner go out of the tooltip container like the image?
The implementation looks good to me. |
danielbarion
changed the title
float effect (follow mouse position)float effect (follow mouse position)
For sure. I just meant instead of v4's
It'll probably not be too hard to add a minimum distance between the tooltip border and the arrow position. |
| - [ ] disableInternalStyle - **Deprecated** | in V5 -> CSS will be a separate file and can be imported or not | ||
| - [x] `children` | ||
| - [x] `place` - also available on anchor element as `data-tooltip-place` | ||
| - [ ] `type` - use `variant`. also available on anchor element as `data-tooltip-variant` |
There was a problem hiding this comment.
Having both the empty brackets [ ] and **Deprecated** seemed redundant.
src/components/Tooltip/Tooltip.tsx
Outdated
| if (float) { | ||
| if (lastFloatPosition) { | ||
| /* | ||
| Without this, changes to `content`, `place`, `offset`, ..., will only | ||
| trigger a position calculation after a `mousemove` event. | ||
|
|
||
| To see why this matters, comment this line, run `yarn dev` and click the | ||
| "Hover me!" anchor. | ||
| */ | ||
| handleTooltipPosition(lastFloatPosition) | ||
| } | ||
| // if `float` is set, override regular positioning | ||
| return () => null | ||
| } |
There was a problem hiding this comment.
For future reference!
TODO
float: booleanprop to addmousemoveevent listener (is there really a need for aneffect: 'solid' | 'float'prop?)placevaluehandleShowTooltip()should also use virtual element whenfloatistrue