Merge pull request #2982 from davidmoten/test-sub-factory-methods

TestSubscriber - add factory methods

Author: akarnokd

src/main/java/rx/observers/TestSubscriber.java

@@ -95,6 +95,31 @@ public TestSubscriber() {
         this(-1);
     }
 
+    @Experimental
+    public static <T> TestSubscriber<T> create() {
+        return new TestSubscriber<T>();
+    }
+    
+    @Experimental
+    public static <T> TestSubscriber<T> create(long initialRequest) {
+        return new TestSubscriber<T>(initialRequest);
+    }
+    
+    @Experimental
+    public static <T> TestSubscriber<T> create(Observer<T> delegate, long initialRequest) {
+        return new TestSubscriber<T>(delegate, initialRequest);
+    }
+    
+    @Experimental
+    public static <T> TestSubscriber<T> create(Subscriber<T> delegate) {
+        return new TestSubscriber<T>(delegate);
+    }
+    
+    @Experimental
+    public static <T> TestSubscriber<T> create(Observer<T> delegate) {
+        return new TestSubscriber<T>(delegate);
+    }
+    
     @Override
     public void onStart() {
         if  (initialRequest >= 0) {

src/test/java/rx/internal/operators/OnSubscribeRangeTest.java

@@ -106,7 +106,7 @@ public void testRangeWithOverflow5() {
     @Test
     public void testBackpressureViaRequest() {
         OnSubscribeRange o = new OnSubscribeRange(1, RxRingBuffer.SIZE);
-        TestSubscriber<Integer> ts = new TestSubscriber<Integer>();
+        TestSubscriber<Integer> ts = TestSubscriber.create();
         ts.assertReceivedOnNext(Collections.<Integer> emptyList());
         ts.requestMore(1);
         o.call(ts);
@@ -127,7 +127,7 @@ public void testNoBackpressure() {
         }
 
         OnSubscribeRange o = new OnSubscribeRange(1, list.size());
-        TestSubscriber<Integer> ts = new TestSubscriber<Integer>();
+        TestSubscriber<Integer> ts = TestSubscriber.create();
         ts.assertReceivedOnNext(Collections.<Integer> emptyList());
         ts.requestMore(Long.MAX_VALUE); // infinite
         o.call(ts);
@@ -137,7 +137,7 @@ public void testNoBackpressure() {
     void testWithBackpressureOneByOne(int start) {
         Observable<Integer> source = Observable.range(start, 100);
 
-        TestSubscriber<Integer> ts = new TestSubscriber<Integer>();
+        TestSubscriber<Integer> ts = TestSubscriber.create();
         ts.requestMore(1);
         source.subscribe(ts);
 
@@ -152,7 +152,7 @@ void testWithBackpressureOneByOne(int start) {
     void testWithBackpressureAllAtOnce(int start) {
         Observable<Integer> source = Observable.range(start, 100);
 
-        TestSubscriber<Integer> ts = new TestSubscriber<Integer>();
+        TestSubscriber<Integer> ts = TestSubscriber.create();
         ts.requestMore(100);
         source.subscribe(ts);
 
@@ -179,7 +179,7 @@ public void testWithBackpressureAllAtOnce() {
     public void testWithBackpressureRequestWayMore() {
         Observable<Integer> source = Observable.range(50, 100);
 
-        TestSubscriber<Integer> ts = new TestSubscriber<Integer>();
+        TestSubscriber<Integer> ts = TestSubscriber.create();
         ts.requestMore(150);
         source.subscribe(ts);