Various fixes #133
Merged
Various fixes #133
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
benjchristensen
commented
Feb 8, 2013
benjchristensen
commented
- restore performance optimization to reduce wrapping
- restoring null check removed in recent commit
Without optimization: runCompositionTest Sum: 710082754 Time: 42.353ms runNonCompositionalTestWithDirectLoop Sum: 710082754 Time: 17.719ms runNonCompositionalTestWithArrayOfFunctions Sum: 710082754 Time: 17.344ms With optimization: runCompositionTest Sum: 710082754 Time: 23.064ms runNonCompositionalTestWithDirectLoop Sum: 710082754 Time: 18.059ms runNonCompositionalTestWithArrayOfFunctions Sum: 710082754 Time: 18.88ms
See ReactiveX@caf3a94 for removal It started causing this unit test to fail: rx.operators.OperationZip$UnitTest > testAggregatorUnsubscribe FAILED java.lang.NullPointerException at OperationZip.java:611 Not sure how I missed it when I reviewed the previous commit … but I did.
jihoonson
pushed a commit
to jihoonson/RxJava
that referenced
this pull request
Mar 6, 2020
Additional tests for events emitters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.