Skip to content

Migrate Build to Nebula #1640

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from

Conversation

benjchristensen
Copy link
Member

@cloudbees-pull-request-builder

RxJava-pull-requests #1541 FAILURE
Looks like there's a problem with this pull request

@benjchristensen
Copy link
Member Author

Failed with:

> License violations were found: /scratch/jenkins/workspace/RxJava-pull-requests/rxjava/src/main/java/rx/internal/operators/TakeLastQueueProducer.java,/scratch/jenkins/workspace/RxJava-pull-requests/rxjava/src/main/java/rx/internal/util/SynchronizedSubscription.java,/scratch/jenkins/workspace/RxJava-pull-requests/rxjava/src/main/java/rx/internal/util/unsafe/MessagePassingQueue.java,/scratch/jenkins/workspace/RxJava-pull-requests/rxjava/src/main/java/rx/internal/util/unsafe/MpmcArrayQueue.java,/scratch/jenkins/workspace/RxJava-pull-requests/rxjava/src/main/java/rx/internal/util/unsafe/ConcurrentCircularArrayQueue.java,/scratch/jenkins/workspace/RxJava-pull-requests/rxjava/src/main/java/rx/internal/util/unsafe/ConcurrentSequencedCircularArrayQueue.java,/scratch/jenkins/workspace/RxJava-pull-requests/rxjava/src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java,/scratch/jenkins/workspace/RxJava-pull-requests/rxjava/src/main/java/rx/internal/util/unsafe/SpscArrayQueue.java,/scratch/jenkins/workspace/RxJava-pull-requests/rxjava/src/main/java/rx/internal/util/unsafe/Pow2.java}

Here is an example file that is failing that shouldn't cause it to fail: https://github.com/ReactiveX/RxJava/blob/1.x/rxjava/src/main/java/rx/internal/util/unsafe/MessagePassingQueue.java

There are some legit ones where it is missing a license. I'll fix those.

@benjchristensen
Copy link
Member Author

I fixed the one that was completely the missing. The rest have a header, but the validation is failing because it is different than it expects. They are all in: https://github.com/ReactiveX/RxJava/tree/1.x/rxjava/src/main/java/rx/internal/util/unsafe

They don't have a Copyright at the top and have comments about where the code originally came from.

/rxjava/src/main/java/rx/internal/util/unsafe/MessagePassingQueue.java
/rxjava/src/main/java/rx/internal/util/unsafe/MpmcArrayQueue.java
/rxjava/src/main/java/rx/internal/util/unsafe/ConcurrentCircularArrayQueue.java
/rxjava/src/main/java/rx/internal/util/unsafe/ConcurrentSequencedCircularArrayQueue.java
/rxjava/src/main/java/rx/internal/util/unsafe/SpmcArrayQueue.java
/rxjava/src/main/java/rx/internal/util/unsafe/SpscArrayQueue.java
/rxjava/src/main/java/rx/internal/util/unsafe/Pow2.java

These should not cause the build to break.

@benjchristensen benjchristensen deleted the nebula-build branch August 29, 2014 21:37
@benjchristensen
Copy link
Member Author

Replaced with #1644

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants