WIP: OnSubscribeRefCount Synchronous #1754
Conversation
|
This adds further unit tests for #1695 and tries an approach that doesn't block threads with locks and non-deterministically break the unit tests. There are still issues with this code. |
| int count = subscriptionCount.getAndIncrement(); | ||
| if (count == 0) { | ||
| // starting a new connection | ||
| final MultipleAssignmentSubscription connectableSubscriptionHolder = new MultipleAssignmentSubscription(); |
There was a problem hiding this comment.
This is not thread-safe because 1 thread could be creating this subscription while a 2nd jumps ahead, registers its subscription then gets a null when it unsubscribes and blows up with an NPE all before the 1st thread finishes creating the MultipleAssignmentSubscription.
We either need locks or to use a State object with a single AtomicReference containing them all in a state machine.
|
I commented on the obvious problems in my code ... the real reason for this being shown is to make my unit tests available. |
|
Closing so no one confuses this for a real PR. |
This is a work in progress... do not merge or use this.
Submitting as PR to allow discussion.