Merge: fixed hangs & missed scalar emissions #2482
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I'm going to merge this so other bugfixes/enhancements can go on. |
akarnokd
added a commit
that referenced
this pull request
Jan 28, 2015
Merge: fixed hangs & missed scalar emissions
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I hunted down the bug that was causing missed value emission if scalar source such as
just()was involved. This either manifested as completion without a value or non-completion because the missing scalar value would sit in the queue and prevented onCompleted from draining. (I've also fixed some visibility issues which might had an effect in this.)In addition, I've discovered a good practice for spuriously failing tests: I create a new
@Testmethod with a loop in it, calling the original test method. This way, the original is not disturbed and the likelihood of failure is increased by the looping test.Since the whole
mergeoperator is quite complicated, I can't be 100% certain this works despite local tests passing.See also #2480, #2466 and #1941.