Skip to content

Timestamp operation #249

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
May 1, 2013
Merged

Timestamp operation #249

merged 7 commits into from
May 1, 2013

Conversation

jmhofer
Copy link
Contributor

@jmhofer jmhofer commented Apr 28, 2013

Straightforward implementation of issue #93, based on OperationMap (without the scheduler version, as map doesn't take a scheduler yet either).

@cloudbees-pull-request-builder

RxJava-pull-requests #109 FAILURE
Looks like there's a problem with this pull request

@jmhofer
Copy link
Contributor Author

jmhofer commented Apr 28, 2013

The failing test has nothing to do with my changes. - I guess it's a sporadic test problem as there's not much difference between 10 and 30 milliseconds...

@benjchristensen
Copy link
Member

This should also be added to Observable shouldn't it?

@cloudbees-pull-request-builder

RxJava-pull-requests #112 FAILURE
Looks like there's a problem with this pull request

@jmhofer
Copy link
Contributor Author

jmhofer commented May 1, 2013

My Eclipse configuration also automatically added a lot of @Override annotations. I hope you don't mind. Otherwise, I can remove them again, of course.

@benjchristensen
Copy link
Member

The '@OverRide' annotations are fine - they are standard Java. They may be missing in some places because this project started with Java 5 compliance and it had the annotations in less places than Java 6.

benjchristensen added a commit that referenced this pull request May 1, 2013
@benjchristensen benjchristensen merged commit bafd440 into ReactiveX:master May 1, 2013
@jmhofer jmhofer deleted the timestamp branch May 1, 2013 21:48
rickbw pushed a commit to rickbw/RxJava that referenced this pull request Jan 9, 2014
jihoonson pushed a commit to jihoonson/RxJava that referenced this pull request Mar 6, 2020
…actory-methods

Additional factory methods - issue ReactiveX#249
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants