Skip to content

Optimized isUnsubscribed check #2762

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2015

Conversation

akarnokd
Copy link
Member

Extracted isUnsubscribed optimization from #2603.

Benchmark                                   (size)   Mode   Samples          1.x        2603    
r.s.ComputationSchedulerPerf.observeOn           1  thrpt         5   104110.926  104707.286
r.s.ComputationSchedulerPerf.observeOn          10  thrpt         5   100723.402  105825.148
r.s.ComputationSchedulerPerf.observeOn         100  thrpt         5    24609.763   65571.461
r.s.ComputationSchedulerPerf.observeOn        1000  thrpt         5     3212.434   13020.027
r.s.ComputationSchedulerPerf.observeOn       10000  thrpt         5      955.002    1555.493  
r.s.ComputationSchedulerPerf.observeOn      100000  thrpt         5       96.628     160.218  
r.s.ComputationSchedulerPerf.observeOn     1000000  thrpt         5        9.508      16.559  
r.s.ComputationSchedulerPerf.subscribeOn         1  thrpt         5   114212.000  114485.516  
r.s.ComputationSchedulerPerf.subscribeOn        10  thrpt         5   112376.809  112270.024  
r.s.ComputationSchedulerPerf.subscribeOn       100  thrpt         5    88433.002  104240.739  
r.s.ComputationSchedulerPerf.subscribeOn      1000  thrpt         5    31503.640   64446.984  
r.s.ComputationSchedulerPerf.subscribeOn     10000  thrpt         5     3932.988    8200.048
r.s.ComputationSchedulerPerf.subscribeOn    100000  thrpt         5      437.626    1439.069
r.s.ComputationSchedulerPerf.subscribeOn   1000000  thrpt         5       43.104     146.385

@benjchristensen
Copy link
Member

Nice improvement.

benjchristensen added a commit that referenced this pull request Feb 21, 2015
@benjchristensen benjchristensen merged commit 48e4db0 into ReactiveX:1.x Feb 21, 2015
@akarnokd akarnokd deleted the SubscriptionOpt branch February 22, 2015 22:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants