Operators toList and toSortedList now support backpressure #2901
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Cool. I'll be using that |
| @@ -101,6 +107,9 @@ public void onNext(T value) { | |||
| } | |||
|
|
|||
| }; | |||
| o.add(result); | |||
There was a problem hiding this comment.
Why can't o just be passed into the Subscriber constructor?
There was a problem hiding this comment.
Because if the result Subscriber receives its Producer via setProducer, the default behavior is to call setProducer on op set by the constructor and thus it can overwrite our SingleDelayedProducer.
|
Good changes. |
benjchristensen
added a commit
that referenced
this pull request
Apr 29, 2015
Operators toList and toSortedList now support backpressure
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for backpressure in
toListandtoSortedList: they emit their buffered content only when downstream actually requested it.Few other notes:
toSortedListtaking ainitialCapacityargument which should help reduce the number of times the buffer needs to be resized.toSortedListis now wrapped once per operator instead of once per subscriber.toSortedListnow returns a modifiableArrayList: since it is a handoff procedure, there is no value in forcing a non-modification constraint on the emitted list (similar totoListeven before this PR).